Change type of allocate64 to uint64_t (backport #9307)#9353
Open
mergify[bot] wants to merge 2 commits into
Open
Change type of allocate64 to uint64_t (backport #9307)#9353mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
Cherry-pick of ba0c456 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
f6e8e42 to
33cbe8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The claim in #3526 that there could be an integer overflow is not true on 64-bit architectures. It could only happen if
size_tis 32-bits. The solution is to change the type ofallocate64touint64_tso that it isn't affected by the architecture. I was puzzled why the variable is calledallocate64but its type issize_t. It turns out that this is a regression that happened in 7576a27. I had previously changed the type touint64_tin e4e3362.This is an automatic backport of pull request #9307 done by Mergify.