Update CodeCov keybase url#9327
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the CodeCov uploader PGP key import URL in GitHub Actions workflows to align with CodeCov Action v7 changes and restore coverage uploads.
Changes:
- Switch Keybase key download from
codecovsecuritytocodecovsecopsin the CodeCov upload steps. - Apply the same change to both the push-to-main and PR Linux special builds workflows.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/on_push_ExtraJobsForMain.yml | Updates the PGP key URL used to verify the CodeCov uploader signature. |
| .github/workflows/on_PR_linux_special_builds.yml | Mirrors the same PGP key URL update for PR builds. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 4
| @@ -52,7 +52,7 @@ jobs: | |||
| ctest --output-on-failure | |||
| # this needs to match th ecommand in on_PR_linux_secial_builds.yml! | |||
| @@ -50,7 +50,7 @@ jobs: | |||
| ctest --output-on-failure | |||
| # this needs to match th ecommand in on_push_ExtraJobsForMain.yml! | |||
| # this needs to match th ecommand in on_PR_linux_secial_builds.yml! | ||
| gcovr --root .. --object-dir . --exclude-unreachable-branches --exclude-throw-branches --xml -o coverage.xml . | ||
| curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --import | ||
| curl https://keybase.io/codecovsecops/pgp_keys.asc | gpg --import |
| # this needs to match th ecommand in on_push_ExtraJobsForMain.yml! | ||
| gcovr --root .. --object-dir . --exclude-unreachable-branches --exclude-throw-branches --xml -o coverage.xml | ||
| curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --import | ||
| curl https://keybase.io/codecovsecops/pgp_keys.asc | gpg --import |
|
@mergify backport 0.28.x |
✅ Backports have been createdDetails
Cherry-pick of f97dedb has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@mergify backport 0.29.x |
✅ Backports have been createdDetails
No pull request needed: No commits between 0.29.x and mergify/bp/0.29.x/pr-9327 |
Our CodeCov upload stopped working because of this change: https://github.com/codecov/codecov-action/releases/tag/v7.0.0