Bound setMediaStream search to the trak atom size (backport #9286)#9319
Merged
Conversation
setMediaStream() scans for "hdlr" in a while(!eof) loop with no size bound. When a file has no "hdlr" atom in the expected position, the loop reads through the entire rest of the file. Pass the trak atom size and stop the search at that boundary. (cherry picked from commit b5cb228)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit fd3f4fb)
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com> (cherry picked from commit ee13a61)
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com> (cherry picked from commit 44b9b7d)
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com> (cherry picked from commit 02d5e63)
(cherry picked from commit 6aef39d)
kmilos
approved these changes
Jun 15, 2026
Collaborator
|
@kevinbackhouse I was maybe too quick to merge this, sorry - changes the API, so not for 0.28.9 in fact, just like #9333? |
Collaborator
Good catch! I agree, probably safer to revert this and include it in 0.29.0 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9285:
setMediaStream() scans for "hdlr" in a while(!eof) loop with no size bound. When a file has no "hdlr" atom in the expected position, the loop reads through the entire rest of the file.
Pass the trak atom size and stop the search at that boundary.
This is an automatic backport of pull request #9286 done by Mergify.