Register prefer-options-object-param in the lighter bundle too - #29
Merged
Merged
Conversation
…le too It reads no type information at all, so excluding it from plugin.configs.recommended withheld a real, zero-cost protection from exactly the consumer that lighter bundle exists for. Registers it in both bundles, matching no-mutable-union-array-param/ prefer-readonly-array-param/test-file-kind/max-params, and updates every comment that previously described the exclusion as deliberate.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #28.
exadev/prefer-options-object-paramreads no type information at all, so excluding it fromplugin.configs.recommendedwithheld a real, zero-cost protection from exactly the consumer that lighter bundle exists for — the family-placement rationale in #28 didn't actually hold up next toprefer-readonly-object-param/prefer-numeric-sort-compare, which are excluded from that bundle for a genuine technical reason (they need the checker to work at all).Changes
src/plugin.ts: added'exadev/prefer-options-object-param': 'error'toconfigs.recommended.rules, and rewrote the surrounding comment to state plainly that it needs no type info and lives in both bundles, matchingno-mutable-union-array-param/prefer-readonly-array-param/test-file-kind/max-params.src/rules/prefer-options-object-param.ts: updated the rule's own file header to match.src/plugin.unit.test.ts: added an assertion thatplugin.configs.recommended.rules['exadev/prefer-options-object-param']is'error', mirroring the existing checks for the other both-bundle rules.README.mdand the rule's own test file comment: updated to match.Test plan
pnpm test— 805 tests green, including the new assertion.pnpm typecheck/pnpm lint/pnpm build— clean.