fix: name the headroom distribution correctly in the default install spec - #31
Merged
Merged
Conversation
…spec uv rejects 'headroom[proxy] @ git+...' because the distribution is headroom-ai; the first supervised install failed on exactly that. The schema default, the supervisor test fixture and the docs example all carried the wrong name.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The fork's default branch still mirrors upstream, which has no /stats/sessions endpoint; until the upstream PR merges, the install must come from the branch that carries it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default
headroom.sourcewasheadroom[proxy] @ git+https://github.com/ExaDev/headroom, but the distribution the fork builds is namedheadroom-ai, souv tool installrefused it ("Package metadata name `headroom-ai` does not match given name `headroom`") and the supervisor's first install failed. The spec now usesheadroom-ai[proxy] @ ..., in the schema default, the supervisor test fixture and the docs example.Testing
pnpm run typecheckpnpm run lintpnpm run test(901 tests)headroom.source, the supervisor'suv tool installsucceeds and the daemon comes upChecklist