[pull] master from beyond-all-reason:master - #258
Merged
Merged
Conversation
Remove the unused maxanglediff and maindir for subs with `turret = false` as it doesn't affect their weapons and draw the ranges using tolerances similarly to what we did for figs. All subs now show the correct firing arc.
The game is currently sending UnitFinished messages which then get caught by SPADS and forwarded to Teiserver as simple match events. We currently have about 12 GBs of these events and they have never been used so rather than filtering them on server, I would prefer to stop them at the source which is the reason for this PR. In case of future desire for this kind of data the approach should be reconsidered anyway (e.g. something like GEX might be more appropriate). Resolves beyond-all-reason/teiserver#1573
### Work done The trajectory/impact drawing change for starburst and verticalize projectiles added excessive reads from a motion state table and calls to get the ground height. This optimizes both reads by replacing accesses with faster stack moves and by skipping ground height checks above the highest collideable point of terrain/water.
### Work done The logs they are a-changin'.
require runs the file in the caller's environment (same as before) and also lets EmmyLua type and analyze its return value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )