Repository navigation
fix(tests): check omp's parsed manifest with an isolated link - #2045
Merged
Merged
Conversation
omp 18.18+ answers `install --dry-run` for a local path without reading package.json, so the smoke test's name and manifest checks failed. The test now runs a real `omp plugin link` into a throwaway HOME and agent dir, which still reports the parsed name and manifest.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The omp native-install smoke test passes again on omp 18.18 and later. It now checks the name and manifest that omp parses from
package.json#pithrough a realomp plugin linkinto a throwaway home directory.Starting with omp 18.18,
omp install --dry-run --json <local path>returns only{dryRun, action: "link", path}and never readspackage.json, so the test's name and manifest assertions failed on any machine with a current omp. CI runners have no omp, so CI skipped the test and missed the failure. The link runs withHOME,PI_CODING_AGENT_DIR, and theXDG_*_HOMEdirs pointed at a temp directory that is removed afterwards. That keeps it out of the user's real~/.omp(omp honors the XDG dirs on Linux). The assertions are unchanged.Validation
bun test tests/omp-native-install.test.tspasses on omp 18.18.5. The existing~/.omp/plugins/node_modules/compound-engineeringsymlink was unchanged after the run.bun run test --changed-since=d293bf4bc(3981 pass, 0 fail),typecheck,release:validate,plugin:validatepass.Security Disclosure
No security-relevant changes. The test now runs a real
omp plugin linkinstead of a dry run, confined to a temporaryHOME, agent dir, and XDG dirs that it deletes afterwards.Agent Disclosure