Skip to content

Fix: resolve environment parity, router lazy loading, API types, and test teardown - #706

Merged
devJaja merged 5 commits into
Epta-Node:mainfrom
dorismaduegbunam:fix/resolve-issues-573-575-576-574
Sep 30, 2026
Merged

devJaja merged 5 commits into
Epta-Node:mainfrom
dorismaduegbunam:fix/resolve-issues-573-575-576-574

Conversation

@dorismaduegbunam

Copy link
Copy Markdown

PR Description

Closes #573
Closes #575
Closes #576
Closes #574

Summary of Changes

Issue #573 — Config Parity & Direct process.env Removal

  • Updated backend/src/config/index.ts Zod envSchema to validate all missing environment variables (RATE_LIMIT_PUBLIC_*, RATE_LIMIT_AUTHED_*, RATE_LIMIT_ADMIN_*, VENICE_MODEL_VERSION, VENICE_CACHE_*, VENICE_REQUEST_TIMEOUT_MS, VENICE_PROVIDER_MAX_RETRIES, VENICE_FALLBACK_*, QUALITY_*, AI_NET_READ_ONLY*, ADMIN_*, FEATURE_*).
  • Updated backend/.env.example to achieve 100% two-way key parity with envSchema. Removed duplicate keys (DATABASE_URL, DAILY_TASK_LIMIT_PER_WALLET), removed legacy PostgreSQL documentation references, and documented DB_POOL_* SQLite WAL read pool parameters.
  • Refactored direct process.env reads across feature modules (agents.ts, auth.ts, errorHandler.ts, rateLimit.ts, tasks.ts, v1/tasks.ts, v2/tasks.ts, versions.ts, cache/registry.ts, db/index.ts, loader.ts, schemas/task.ts, adminControl.ts, tokenService.ts, featureFlags.ts, idempotency.ts, qualityScorer.ts, venice/client.ts) to use getConfig().
  • Added automated two-way parity test in backend/tests/config.test.ts and process env assertion guard in backend/tests/no-direct-process-env.test.ts.

Issue #575 — Frontend Route Imports & Suspense Fallback

  • Updated lazy component imports in frontend/src/App.tsx (./pages/dashboard, ./pages/WalletPage, ./pages/AgentsPage, ./pages/tasks/NewTaskPage, ./pages/tasks/TaskHistoryPage, ./pages/TaskDetailPage, ./pages/RendererDemoPage) to ensure default export compatibility.
  • Wrapped routed components in <Suspense fallback={<RouteLoader />}>.
  • Extended frontend/src/components/auth/ProtectedRoute.test.tsx to verify /tasks/history.

Issue #576 — TaskDetailPage Cleanup & API Type Consolidation

  • Cleaned unused reactflow imports from frontend/src/pages/TaskDetailPage.tsx while preserving component rendering.
  • Consolidated redundant types in frontend/src/types/api.ts (DAGNode/DagNode unified, CursorPage/CursorPageEnvelope consolidated).
  • Added comprehensive unit test suite in frontend/src/pages/TaskDetailPage.test.tsx.

Issue #574 — Backend Coverage Exclusions & Teardown Cleanup

  • Removed exclusions (!src/**/index.ts, !src/registry/sync.ts, !src/api/routes/stream.ts, !src/index.ts, !src/checkSpec.ts) from backend/jest.config.js.
  • Removed duplicate orphan file backend/tests/globalTeardown.ts, retaining backend/tests/global-teardown.ts.

@vercel

vercel Bot commented Sep 29, 2026

Copy link
Copy Markdown

@dorismaduegbunam is attempting to deploy a commit to the Jaja's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@dorismaduegbunam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@devJaja

devJaja commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@dorismaduegbunam

Kindly resolve the conflicts

@devJaja
devJaja merged commit 8fb9ac2 into Epta-Node:main Sep 30, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment