feat(smart-contracts): comprehensive unit and integration test covera…

[CHKM001]

PR #489 feat(smart-contracts): Comprehensive Unit and Integration Test Coverage

Branch: feat/issue-489-comprehensive-contract-test-coverage → main

---

Summary

This PR adds comprehensive snapshot-backed unit tests and an integration test harness across all Stellar smart contracts in the smart-contracts/ workspace. Prior to this change, only agent_registry and agent_governance had meaningful test coverage. All other contracts had minimal or no tests, blocking mainnet deployment confidence.

---

What Changed

New Test Files

Contract	File	Tests Added
agent_bidding	src/tests.rs	17 unit tests
agent_marketplace	src/test.rs	16 unit tests
dispute_resolution	src/test.rs	16 unit tests
error-registry	src/lib.rs (inline)	20 unit tests
error-resolver	src/agent_errors.rs (inline)	14 unit tests
upgrade-manager	src/lib.rs (inline)	9 unit tests
task_store	src/lib.rs + src/types.rs	Lifecycle & auth tests
Integration	tests/integration/src/lib.rs	Cross-contract wiring tests

Test Coverage by Contract

agent_bidding

• Initialization (idempotency, admin/version set)
• Auction creation: success, duplicate ID rejection, pause guard, invalid bond/price
• Bid submission: success, errors (wrong phase, wrong caller)
• Reveal phase: success, errors, winner selection with tie-break and reputation weighting
• Refund: recovery from stalled auctions, idempotency guard, timing constraints
• Admin: pause/unpause authorization, version upgrade

agent_marketplace

• Initialization idempotency and admin assignment
• Service listing: success, duplicate rejection, invalid price validation
• Search: filter by max price, filter by max response time, works-when-paused
• Booking: sufficient-payment success, insufficient-payment rejection
• Booking completion: escrow release, error cases (wrong caller, wrong state)
• Booking cancellation: client refund, error cases
• Rating: score update, invalid score rejection, error cases
• Pause: blocks listing and booking completion

dispute_resolution

• Initialization and idempotency
• file_dispute: success, duplicate rejection, no-jurors rejection
• set_jurors: success and authorization guard
• cast_vote: success, non-juror rejection, duplicate-vote rejection
• submit_evidence: success, error cases (wrong state, wrong caller)
• resolve_dispute: after-voting (client wins), agent-wins path
• appeal_dispute: success within window, rejection after window, error cases
• Pause: blocks filing and juror assignment; reads still work when paused

error-registry

• TTL validation: zero, overflow, above-max, at-max-accepted
• Submit: success with expires_at stored, duplicate rejection
• Cleanup: batch cap enforced, active records skipped, mixed batch, code-index maintained, boundary timestamp semantics, noop on empty, works-when-paused
• get_error / get_errors_by_code: hides expired records, skips expired
• Pause: blocks submit; reads unaffected

error-resolver

• Initialization idempotency and admin/signer set
• Error counting: record and query, unknown agent returns zero, clear resets to zero
• Allowlist: admin can add/remove directly, non-admin rejected
• Multisig: signer add/remove, approve, execute with quorum, cannot approve twice, non-signer blocked
• Timelock: execute fails before timelock expires
• Quorum: set_quorum works
• Audit log: operations recorded

upgrade-manager

• Initialization and idempotency
• Admin and authorization assignment
• Propose and execute upgrade (semver increment enforced)
• Downgrade rejection
• Rollback within window and after deadline
• Pause blocks operations
• Execution of unvalidated proposal fails
• Gas estimation

Integration (tests/integration)

• Cross-contract wiring tests using soroban_sdk::testutils
• upgrade-manager linked as rlib (no WASM exports) to avoid Windows/MinGW linker ordinal overflow

Bug Fixes Made During Test Authoring

File	Fix
dispute_resolution/src/test.rs	Removed invalid lifetime from Vec<Address>; fixed Error variant names to match lib.rs
error-registry/src/lib.rs	Removed duplicate require_admin definition; fixed mismatched closing braces
error-resolver/src/agent_errors.rs	Removed redundant require_not_paused checks on read paths; fixed orphaned brace
upgrade-manager/src/lib.rs	Scoped mod tests to #[cfg(all(test, feature = "contract"))] to prevent double-export
tests/integration/Cargo.toml	Changed upgrade-manager dep to default-features = false to avoid linker ordinal overflow on Windows

---

Test Execution

# All contracts — unit tests
cd smart-contracts

cargo test -p agent_bidding
cargo test -p agent_marketplace
cargo test -p dispute_resolution
cargo test -p error-registry
cargo test -p error-resolver --no-default-features --features std
cargo test -p upgrade-manager --features contract
cargo test -p task_store
cargo test -p agent_governance

# Integration
cargo test -p integration

All tests pass on the current workspace. Snapshots are committed alongside the test source.

---

Notes for Reviewers

• Windows linker constraint: Building upgrade-manager with the contract feature in the integration harness triggers an "export ordinal too large" error under MinGW/MSVC. The integration Cargo.toml now depends on it as default-features = false (pure rlib) which resolves this. This does not affect the WASM build pipeline.
• Snapshot files: All test_snapshots/**/*.json files are auto-generated by soroban_sdk's snapshot harness on first run. They are committed to lock expected ledger state and will fail CI if contract logic drifts.
• error-resolver test feature flag: Run with --no-default-features --features std to avoid the WASM ABI conflicting with the test runtime linker.

---

Checklist

• All new tests pass locally
• Snapshot JSON files committed
• No hardcoded credentials or private keys
• Existing tests unbroken (agent_registry, agent_governance snapshots updated to reflect voting power weighting changes)
• Conventional commit message used
• Resolves #489 referenced

Closes #489

[drips-wave]

@CHKM001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[vercel]

@CHKM001 is attempting to deploy a commit to the Jaja's projects Team on Vercel.

A member of the Team first needs to authorize it.

[devJaja]

@CHKM001

Kindly resolve the conflicts

[CHKM001]

DONE!