Skip to content

[Feature request] nn.seqBRNN ability to stack and maskZero() #421

Description

@jpilaul

I am currently doing something like this:
brnn = nn.seqBRNN(vec_size,rnn_size)
brnn.forwardModule:maskZero()
brnn.backwardModule:maskZero()
I have extended seqBRNN to add the ability stack seqBRNN with a stack_size argument that adds modules in a loop. I also added a seqBRNN:maskZero() method on my local repo.

If this is something that you might want, should I send a merge request?

Thanks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions