Skip to content

🎨 Palette: Improve accessibility of filter buttons in coverage view #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EffortlessSteven wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🎨 Palette: Improve accessibility of filter buttons in coverage view #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

## 2026-06-29 - [Filter Button Accessibility]
**Learning:** Maud templates (`html!`) do not easily support dynamic boolean attributes evaluated conditionally at runtime via JavaScript.
**Action:** For UI components like filter buttons, establish static initial states (e.g., `aria-pressed="true"`) and update them using vanilla JS (e.g., `setAttribute('aria-pressed', 'true')`) to ensure proper accessibility communication to screen readers.
15 changes: 9 additions & 6 deletions crates/app-http/src/platform/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,8 +691,11 @@ pub async fn coverage_view(State(state): State<AppState>) -> Html<String> {
// Update active button
document.querySelectorAll('.filter-btn').forEach(btn => {
btn.classList.remove('active');
btn.setAttribute('aria-pressed', 'false');
});
document.getElementById('filter-' + status).classList.add('active');
const activeBtn = document.getElementById('filter-' + status);
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');
Comment on lines +696 to +698

@gemini-code-assist gemini-code-assist Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If document.getElementById returns null (e.g., due to an unexpected status or DOM state), calling classList.add or setAttribute directly on activeBtn will throw a runtime TypeError and halt subsequent JavaScript execution. Adding a safety check ensures the script fails gracefully.

Suggested change
const activeBtn = document.getElementById('filter-' + status);
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');
const activeBtn = document.getElementById('filter-' + status);
if (activeBtn) {
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');
}


// Apply filter
applyFilters();
Expand Down Expand Up @@ -800,11 +803,11 @@ pub async fn coverage_view(State(state): State<AppState>) -> Html<String> {
.card {
h2 { "Acceptance Criteria Coverage" }
.filter-controls data-uiid="coverage.filters" {
button #filter-all.filter-btn onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
button #filter-all.filter-btn aria-pressed="true" onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn aria-pressed="false" onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn aria-pressed="false" onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn aria-pressed="false" onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="search" aria-label="Search acceptance criteria" placeholder="Search by AC ID or title..."
oninput="searchData()";
}

Expand Down
15 changes: 9 additions & 6 deletions crates/http-platform/src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,11 @@ fn coverage_content() -> Markup {
.card {
h2 { "Acceptance Criteria Coverage" }
.filter-controls data-uiid="coverage.filters" {
button #filter-all.filter-btn onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
button #filter-all.filter-btn aria-pressed="true" onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn aria-pressed="false" onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn aria-pressed="false" onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn aria-pressed="false" onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="search" aria-label="Search acceptance criteria" placeholder="Search by AC ID or title..."
oninput="searchData()";
}

Expand Down Expand Up @@ -766,8 +766,11 @@ fn coverage_script() -> &'static str {
// Update active button
document.querySelectorAll('.filter-btn').forEach(btn => {
btn.classList.remove('active');
btn.setAttribute('aria-pressed', 'false');
});
document.getElementById('filter-' + status).classList.add('active');
const activeBtn = document.getElementById('filter-' + status);
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');
Comment on lines +771 to +773

@gemini-code-assist gemini-code-assist Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If document.getElementById returns null (e.g., due to an unexpected status or DOM state), calling classList.add or setAttribute directly on activeBtn will throw a runtime TypeError and halt subsequent JavaScript execution. Adding a safety check ensures the script fails gracefully.

Suggested change
const activeBtn = document.getElementById('filter-' + status);
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');
const activeBtn = document.getElementById('filter-' + status);
if (activeBtn) {
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');
}


// Apply filter
applyFilters();
Expand Down
Loading