Skip to content

test: expand changelog parser coverage#553

Open
EffortlessSteven wants to merge 1 commit into
mainfrom
codex/improve-unit-testing-94wuml
Open

test: expand changelog parser coverage#553
EffortlessSteven wants to merge 1 commit into
mainfrom
codex/improve-unit-testing-94wuml

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Motivation

  • Increase unit test coverage for the changelog parser to cover additional real-world and edge-case headers and section handling.
  • Ensure the parser correctly handles semantic versions with prerelease and build metadata, rejects malformed headers, and ignores list items that appear before any section.
  • Verify round-trip preservation of Deprecated and Security sections to prevent regressions when serializing/deserializing.

Description

  • Added multiple new unit tests in crates/changelog/src/lib.rs including test_parse_prerelease_and_build_metadata_header, test_parse_rejects_misordered_version_brackets, test_parse_rejects_invalid_semver, test_parse_ignores_list_items_before_any_section, and test_roundtrip_preserves_security_and_deprecation_sections to validate parser behavior.
  • Kept existing API and parser logic unchanged; tests exercise parse_version_header, ChangelogEntry::from_markdown, and to_markdown round-trip behavior.
  • Ran workspace formatting to keep code style consistent using the repository formatting helper.

Testing

  • Ran python scripts/cargo_fmt_workspace.py to format workspace crates, which completed successfully.
  • Ran cargo test -p racing-wheel-changelog and all added and existing unit tests passed (19 passed, 0 failed).
  • Ran cargo clippy -p racing-wheel-changelog --all-targets --all-features -- -D warnings, which completed without reported warnings or errors.

Codex Task

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 17, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 48 minutes and 32 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1cabaca2-5519-41b8-bd83-ce647a610222

📥 Commits

Reviewing files that changed from the base of the PR and between d836f5b and ccfc418.

📒 Files selected for processing (1)
  • crates/changelog/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-unit-testing-94wuml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@factory-droid

factory-droid Bot commented May 17, 2026

Copy link
Copy Markdown

Droid finished @EffortlessSteven's task —— View job


LGTM — no high-confidence issues found; the PR adds targeted unit tests and improves changelog parser coverage without changing production logic.

@github-actions

Copy link
Copy Markdown

Compatibility Layer Usage Report

Current usage count: 193
Baseline usage count: 193
ℹ️ Usage unchanged

📈 Usage Trend (Last 30 Days)

  • Peak usage: 193
  • Current trend: insufficient_data (0%)
  • Projected removal: unknown

Usage Details

  • /home/runner/work/OpenRacing/OpenRacing/crates/engine/src/compat_impl.rs:69 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/engine/src/hid/linux.rs:1253 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/engine/src/hid/linux.rs:1282 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/engine/src/hid/mod.rs:230 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/engine/src/protocol.rs:290 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/engine/src/protocol.rs:742 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/engine/src/protocol.rs:749 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/schemas/src/service_example.rs:189 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/schemas/src/service_example.rs:218 - temp_c
  • /home/runner/work/OpenRacing/OpenRacing/crates/schemas/src/integration_test.rs:79 - temp_c

... and 183 more occurrences

Migration Guide

To migrate these usages, replace:

  • .temp_c().temperature_c
  • .faults().fault_flags
  • .wheel_angle_mdeg().wheel_angle_deg
  • .wheel_speed_mrad_s().wheel_speed_rad_s

See Migration Patterns for detailed examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant