Refactor ADR tool helpers#535
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Droid finished @EffortlessSteven's task —— View job Review complete. LGTM — validated the candidate set (no inline comments) and found no high-confidence correctness or security issues in this refactor to shared ADR/console helpers. |
Compatibility Layer Usage ReportCurrent usage count: 193 📈 Usage Trend (Last 30 Days)
Usage Details
... and 183 more occurrences Migration GuideTo migrate these usages, replace:
See Migration Patterns for detailed examples. |
Motivation
validate-adrandgenerate-docs-indexby providing a single shared implementation.Description
openracing_toolslibrary surface (crates/tools/src/lib.rs) that exposesadrandconsolemodules.adrhelpers incrates/tools/src/adr.rscovering ADR filename/title parsing, ADR discovery (find_adr_files), and ISO date checking (is_iso_date).crates/tools/src/console.rsfor consistentstdout/stderrline output.crates/tools/src/bin/generate_docs_index.rsandcrates/tools/src/bin/validate_adr.rsto import and reuse the shared helpers and removed the duplicated implementations from those binaries.fuzz/Cargo.lockuntouched.Testing
python scripts/cargo_fmt_workspace.py, which completed successfully.cargo test -p openracing-tools, and all tests for the tools crate passed.cargo clippy -p openracing-tools --all-targets --all-features -- -D warnings, and the check completed with no warnings.Codex Task