🛡️ Sentinel: [CRITICAL] Fix Request Smuggling via chunked encoding bypass#6311
🛡️ Sentinel: [CRITICAL] Fix Request Smuggling via chunked encoding bypass#6311EffortlessSteven wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚨 Severity: CRITICAL
💡 Vulnerability: The Axum middleware relied solely on checking the
content-lengthheader to enforce request body size limits, which allowed attackers to bypass the limit using chunked encoding (Transfer-Encoding: chunked), potentially leading to request smuggling and DoS.🎯 Impact: Attackers could send arbitrarily large requests bypassing the payload limit, resulting in memory exhaustion and potential HTTP desync attacks against the server.
🔧 Fix: Replaced the manual
content-lengthcheck in the main middleware stack with Axum'sDefaultBodyLimitto enforce body size limits globally and added explicit rejection of chunked encoding in the request sanitization middleware.✅ Verification: Ran
cargo check,cargo fmt,cargo clippy, andcargo testonbitnet-serverto ensure the application compiles and functions correctly.PR created automatically by Jules for task 14643378848909692049 started by @EffortlessSteven