Skip to content

🛡️ Sentinel: [CRITICAL] Fix Request Smuggling via chunked encoding bypass#6311

Draft
EffortlessSteven wants to merge 1 commit into
mainfrom
sentinel-fix-request-smuggling-14643378848909692049
Draft

🛡️ Sentinel: [CRITICAL] Fix Request Smuggling via chunked encoding bypass#6311
EffortlessSteven wants to merge 1 commit into
mainfrom
sentinel-fix-request-smuggling-14643378848909692049

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

🚨 Severity: CRITICAL
💡 Vulnerability: The Axum middleware relied solely on checking the content-length header to enforce request body size limits, which allowed attackers to bypass the limit using chunked encoding (Transfer-Encoding: chunked), potentially leading to request smuggling and DoS.
🎯 Impact: Attackers could send arbitrarily large requests bypassing the payload limit, resulting in memory exhaustion and potential HTTP desync attacks against the server.
🔧 Fix: Replaced the manual content-length check in the main middleware stack with Axum's DefaultBodyLimit to enforce body size limits globally and added explicit rejection of chunked encoding in the request sanitization middleware.
✅ Verification: Ran cargo check, cargo fmt, cargo clippy, and cargo test on bitnet-server to ensure the application compiles and functions correctly.


PR created automatically by Jules for task 14643378848909692049 started by @EffortlessSteven

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f3b1893d-cf28-4969-bdb2-47ac207d4b2d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sentinel-fix-request-smuggling-14643378848909692049

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant