Fix stack overflow in calculateLatestCheckpoint#95
Merged
Conversation
Replace Math.max(...spread) with reduce to avoid exceeding the call stack when a document's versions array is very large.
peachbits
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Math.max(...spread) with reduce to avoid exceeding the call stack when a document's versions array is very large.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Low Risk
Small, localized algorithm change in checkpoint calculation plus a changelog entry; behavior should be equivalent but could affect sum/version math if the reduce logic is incorrect.
Overview
Fixes a potential call-stack overflow in
calculateLatestCheckpointwhen processing documents with very largeversionsarrays.Replaces the
Math.max(...spread)computation ofpreviousVersionwith an iterativereduce, and adds a CHANGELOG entry documenting the fix.Written by Cursor Bugbot for commit 0ddd7bc. This will update automatically on new commits. Configure here.