Fix search to resolve abbreviations by expanding their body#977
Merged
Conversation
Previously, searching for a bare abbreviation name (e.g. `search mu1`) would wrap the abbreviation body in a lambda over its arguments, producing a pattern like `fun d x => mu d (pred1 x)`. No axiom contains such a lambda as a subformula, so the search always returned no results. Instead, register the abbreviation arguments as pattern variables and use the body directly as the search pattern. This correctly matches axioms containing the expanded form of the abbreviation.
Gustavo2622
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchcommand to correctly handle bare abbreviation names (e.g.search mu1)Test plan
search mu1returns results (67 lemmas fromDistr)search (mu1 _ _)returns the same results (applied form, already worked)search mustill works (plain operator, unchanged path)ByPathlookupbar x = foo x x) correctly match/exclude