chore: test infrastructure improvements (#821, #822, #824, #932)#1779
Open
SharifIbrahimDev wants to merge 5 commits into
Open
chore: test infrastructure improvements (#821, #822, #824, #932)#1779SharifIbrahimDev wants to merge 5 commits into
SharifIbrahimDev wants to merge 5 commits into
Conversation
|
@SharifIbrahimDev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great job so far There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass? |
added 4 commits
June 26, 2026 15:55
…nto fix/test-infra-improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements foundational testing infrastructure improvements across the frontend and backend, enabling more robust CI workflows and local development verification.
Why?
Closes #821 — [FE-032] Add API client mocks for lib/api/quests.test.ts to avoid live env dependency
Closes #822 — [FE-033] Split frontend tests into unit and integration scripts
Closes #824 — [FE-035] Add smoke test for root layout hydration with global error boundary
Closes #932 — [BE-021] Add backend .env.test loading strategy for e2e/integration
Type of Change
Infrastructure / Testing
How was it tested?
FE-032/FE-033: MSW lifecycle added (server.listen(), server.close()) to ensure the tests run purely against mocked local state. vitest.config.ts matches script parameters via --exclude and --include to seamlessly split test:unit and test:integration.
FE-035: Basic un-mocked hydration check established via render() guaranteeing global boundaries compile properly.
BE-021: Unified .env.test configuration injected directly into setup-e2e-env.ts matching existing integration strategies.
Checklist
Tests added and passing
Follows project conventions
Risk
None — Purely testing enhancements. Does not impact production artifacts.