Skip to content

Add ability to multi-select and copy/paste - #362

Open
Raptor399 wants to merge 5 commits into
EVerest:mainfrom
Raptor399:feat/001-ui-copy-paste
Open

Add ability to multi-select and copy/paste#362
Raptor399 wants to merge 5 commits into
EVerest:mainfrom
Raptor399:feat/001-ui-copy-paste

Conversation

@Raptor399

Copy link
Copy Markdown

Change the UI to allow for selecting multiple modules at once and use Copy/Cut/Paste on them.

Change the UI to allow for selecting multiple modules at once and use
Copy/Cut/Paste on them.

Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
@lukas-mertens

Copy link
Copy Markdown
Collaborator

@Raptor399 Seems like the pipeline mostly ran successful, just the Cypress part didn't, everything else was permission errors, which are just because this PR comes from another Repo.

The Cypress one looks like it only happens on chromium. I recall having some issues in another project with cypress + copy & paste stuff. Maybe you can test if it works locally with chromium or if it is a pipeline issue? Also test it in headless mode, so cypress run if possible. Thanks!

Added check to see if the "create config" button is actually visible before clicking it.
Removed unnecessary duplicate code for local `addModule`.

Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
@Raptor399

Copy link
Copy Markdown
Author

@lukas-mertens Strange! The E2E tests run fine on headless Electron, Chrome, Firefox, and Edge locally.

That being said, I found the culprit from the screenshots - apparently the "Available configs" tab isn't always open, hiding the "Create Config" button so it cannot be clicked. And having no config then dooms the remainder of every failing test.

I've made changes to make sure the Create Config button is visible before clicking it.

Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants