Add Dockerfile and Docker Compose configuration - #342
Conversation
Signed-off-by: Wojtek Siudzinski <admin@suda.pl>
14f2fc3 to
27fa812
Compare
lukas-mertens
left a comment
lukas-mertens
left a comment
There was a problem hiding this comment.
Hi, thank you for contributing!
| volumes: | ||
| - .:/app | ||
| - /app/node_modules | ||
| command: sh -c "npm install && npm run dev" |
There was a problem hiding this comment.
We are using pnpm, not npm
| COPY . . | ||
|
|
||
| # Build the application | ||
| RUN npm run build |
There was a problem hiding this comment.
We are using pnpm, not npm
| WORKDIR /app | ||
|
|
||
| # Copy package files | ||
| COPY package.json package-lock.json* ./ |
There was a problem hiding this comment.
A package-lock.json should not exist, if working with pnpm
| everest-admin-panel-dev: | ||
| image: node:22-alpine | ||
| container_name: everest-admin-panel-dev | ||
| working_dir: /app |
There was a problem hiding this comment.
Not sure if this is the best networking setup, as both are running on the same port. Maybe this works with the bridge network you set up, didn't test it.
Also I think having both the dev setup and the demo setup in one docker-compose is likely not what we want. I feel it would be a better idea to have e.g. a separate docker-compose.dev.yml for the people that need it? Otherwise docker compose up just starts both...
Also I don't know if one really wants to use a docker compose for development, having a devcontainer would be the better alternative in my opinion.
2 participants
This PR adds basic Docker configuration for development and hosting the admin panel. The idea is to build it automatically with the release and be able to include it in the
everest-demoDocker Compose.I didn't add any GitHub actions (especially after the recent “Shai Hulud 2” Supply Chain Attack) but please let me know if I should add it too.