Skip to content

Fix C++20 CMake build configuration: enforce standard and fix style - #8560

Closed
tcclevenger with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-comments-in-review-thread
Closed

tcclevenger with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-comments-in-review-thread

Conversation

Copilot AI commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Address review comments on the C++20 migration: add CMAKE_CXX_STANDARD_REQUIRED ON so configure fails early on incompatible toolchains, and fix style inconsistencies in the Homme block.

Changes

  • components/CMakeLists.txt — Bump to C++20 and add CMAKE_CXX_STANDARD_REQUIRED ON
  • components/eamxx/CMakeLists.txt — Replace the if (NOT CMAKE_CXX_STANDARD) guard with an unconditional set + required, matching components/CMakeLists.txt
  • components/homme/CMakeLists.txt — Add C++20 default inside the standalone IF block, using the file's existing uppercase commands and proper indentation
# components/CMakeLists.txt and components/eamxx/CMakeLists.txt
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

# components/homme/CMakeLists.txt (inside IF (NOT DEFINED PROJECT_NAME))
  IF (NOT CMAKE_CXX_STANDARD)
    SET (CMAKE_CXX_STANDARD 20)
  ENDIF ()

Copilot AI changed the title [WIP] Fix code based on review comments Fix C++20 CMake build configuration: enforce standard and fix style Jul 14, 2026
Copilot AI requested a review from tcclevenger July 14, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants