Skip to content

ci: remove superseded ensure actions pin job DK-5938 - #225

Merged
raffis merged 1 commit into
masterfrom
DK-5938-2
Sep 7, 2026
Merged

raffis merged 1 commit into
masterfrom
DK-5938-2

Conversation

@raffis

@raffis raffis commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

This is an automated PR

Current situation

So far we validated our action pipelines in order to ensure all actions have been pinned to a digest.
However github has introduced a new feature which is a simple org wide setting which renders this job not needed anymore.

Proposal

Remove job.


Summary by cubic

Removes the ensure-sha-pinned job from the PR workflow. The job is no longer needed because GitHub’s org-wide setting now enforces action pinning, which covers the same concern.

Written for commit 900f745. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Security

    • Tightened automation permissions by removing default access not required during pull request workflows.
  • Chores

    • Applied minor workflow formatting cleanup.

@raffis
raffis requested a review from a team as a code owner September 7, 2026 07:43
@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: DoodleScheduling/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: f0da270a-e32d-4488-9c46-3f406da1c439

📥 Commits

Reviewing files that changed from the base of the PR and between 16df770 and 900f745.

📒 Files selected for processing (1)
  • .github/workflows/pr-actions.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/pr-actions.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workflow now sets an empty top-level permissions block. The pull_request trigger remains limited to the master branch.

Changes

Workflow security settings

Layer / File(s) Summary
Disable default workflow permissions
.github/workflows/pr-actions.yaml
The workflow adds permissions: {} and retains the master branch filter for pull_request events.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 900f7

The workflow removes the obsolete digest-pinning validation and disables default token permissions. No concrete merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the removal of the superseded CI job that validated GitHub Actions pinning. This matches the pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DK-5938-2

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@raffis
raffis merged commit 461b997 into master Sep 7, 2026
19 of 21 checks passed
@raffis
raffis deleted the DK-5938-2 branch September 7, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant