Conversation
A problem set has no way to include an introduction, a section header, or shared setup text — every child document is a scored, numbered problem. The viewer already has the concept: `SingleDocSource.isDescription` marks a document as unscored and unnumbered. Nothing here can set it. This adds only the column, with no code reading it, so that the migration can be applied on its own. That matters more than usual here: `ADD COLUMN` on `content` cannot use instant DDL — its two FULLTEXT indexes force a full `ALGORITHM=COPY` rebuild, measured at 7 min 3 s on dev3 against a 5-minute deploy timeout. The deploy kills it mid-rebuild, and because MySQL DDL is not transactional the column commits while Prisma's bookkeeping does not, leaving `_prisma_migrations` unfinished. Every subsequent deploy then fails with `P3009` — including a rollback — until someone runs `prisma migrate resolve` by hand. This already happened on dev3 (2026-08-15 02:30 UTC). `MANUAL_MIGRATION_PLAN.md` is the runbook for applying it to prod by hand, with the pre-flight results already gathered. Tracked in Doenet#3027. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cqnykamp
force-pushed
the
split/is-description-column
branch
from
August 20, 2026 01:47
9dc8d31 to
a06130f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the column is for
A problem set has no way to include an introduction, a section header, or shared setup text — every child document is a scored, numbered problem.
The viewer already has the concept.
SingleDocSource.isDescriptionmarks a document as unscored and unnumbered, and it is already implemented there for question numbering, credit, shuffle anchoring, and the per-item attempt button. There is just no way to set it. This column is where that setting will live.Nothing reads it yet; the API that uses it is a separate PR. Applying this on its own changes no behavior.
Why it ships on its own
ADD COLUMNoncontentcannot use instant DDL. The table carries two FULLTEXT indexes (content_name_idx,content_source_idx), which force InnoDB all the way back toALGORITHM=COPY— a full table rebuild. On dev3 that took 7 minutes 3 seconds, against a 5-minute deploy timeout.The deploy kills the rebuild partway through. MySQL DDL is not transactional, so the column commits while Prisma's bookkeeping does not, leaving
_prisma_migrationswith an unfinished row. Every subsequent deploy then fails withP3009— including a rollback tomain— until someone runsprisma migrate resolveby hand. This is not hypothetical; it happened on dev3 on 2026-08-15 at 02:30 UTC.Prod's
contenttable is larger, so expect longer, with writes blocked for the duration. The underlying timeout problem is tracked in #3027.Keeping the migration in its own PR means that window gets scheduled and reviewed on its own, and nothing else has to roll back with it.
🤖 Generated with Claude Code