Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steam's handling of the Status and RichPresence flags in ClientRequestFriendData appears to be broken. In my testing, requesting Status can return incomplete or incorrect persona state data, while requesting RichPresence can cause existing rich presence data to be cleared.
Since Steam echoes ClientPersonaState messages to all clients logged in as the same account, these bad updates also affect the official Steam client. This can be reproduced by logging into the official client and then requesting friend persona data through steam-user; friends may appear offline or lose their rich presence.
Removing both flags fixes the issue in my testing. Correct status and rich presence data are still received through Steam's normal ClientPersonaState updates for online friends.