[#147]Convert to Kotlin- data/remote/model/NoteRemote.java - #193
Open
OmneyaOsman wants to merge 2 commits into
Open
OmneyaOsman wants to merge 2 commits into
OmneyaOsman wants to merge 2 commits into
Conversation
Added message when there is no network connection
1-Add new data kotlin class NoteRemote in data/remote/model package with fields provided in NoteRemote.java but in kotlin . 2-remove NoteRemote.java
CarlosRodrigo
requested changes
Nov 4, 2019
CarlosRodrigo
left a comment
CarlosRodrigo
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for your contribution!
it seems that you branched out from the wrong branch because there is a commit from another developer on this PR.
Could you please branch out from dev and push your changes again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1-Add new data kotlin class NoteRemote in data/remote/model package with fields provided in NoteRemote.java but in kotlin .
2-remove NoteRemote.java