Fix security and architecture issues on codebase-discovery skill - #4
Open
bsigney wants to merge 15 commits into
Open
Fix security and architecture issues on codebase-discovery skill#4bsigney wants to merge 15 commits into
bsigney wants to merge 15 commits into
Conversation
asadiq-dius
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix state continuity and coverage reporting in
codebase-discoveryPhase 0 and resume
docs/_discovery/in step 1 and agreed the destination in step 4.--freshrunsgit ls-filesbefore telling the user what is recoverable, and names the case where git is unavailable.code-onlyand for state that did not survive a clone, and now names phases for the drift case.Coverage
provenance-and-status.md, with a producer for each and consumers in Phase 3, the entry point, Phase 4 and the completion report.current-architecture.mdcarries the component-to-area mapping and flags components recon never read with[unchecked].Write safety
README.mdand the agent file, and rule 6 blocks re-initialising the two committed audit files.current-architecture.mdanddiscovery-state.mdcarry the secrets-rule pointer thatintegrations.mdalready had.Consistency
Areacolumn for area-specific terms.code-onlymode, where nothing is stakeholder-confirmed.C-nandFR-n/NFR-n.node scripts/validate.jspasses.