Skip to content

feat: Spanish and Arabic, with right-to-left support - #38

Merged
DevPlus31 merged 2 commits into
mainfrom
feat/arabic-spanish-locales
Oct 29, 2026
Merged

DevPlus31 merged 2 commits into
mainfrom
feat/arabic-spanish-locales

Conversation

@DevPlus31

@DevPlus31 DevPlus31 commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Summary

Languages

  • Spanish (es) and Arabic (ar) for the shell, every module, Laravel's validation/auth/passwords/pagination groups, and the legal document templates
  • Arabic plurals carry all six forms (Laravel and laravel-react-i18n both pick among them)

Right to left

  • An unset direction follows the locale (Direction::forLocale), so Arabic reads rtl; a direction the user picked still wins
  • The layout cookie keeps only the options chosen, so a stored default no longer pins the direction
  • Sidebar side is logical (start = right in rtl): it no longer overlaps the content in rtl, and "Sidebar end" no longer overlaps it in ltr
  • Logical utilities in the shadcn primitives (table, select, dropdown, command, dialog, sheet); mirrored breadcrumb, submenu and panel icons; verification codes and the ⌘K hint stay ltr
  • theme-lint's physical-direction rule now covers components/ui

Test plan

  • Unit + Feature suites (1,257 tests), PHPStan, Pint, Rector, type coverage 100%
  • tsc, oxlint, oxfmt, theme lint
  • Browser suite (119 tests, incl. new ArabicTest) against a production build; ArabicTest fails against the old sidebar
  • Line coverage 100% and PostgreSQL job — CI
  • Native-speaker review of the Arabic and Spanish wording

🤖 Generated with Claude Code

DevPlus31 and others added 2 commits October 29, 2026 23:49
- Spanish (es) and Arabic (ar) catalogues for the shell and every module,
  Laravel's validation/auth/passwords/pagination groups, and the legal
  document templates; Arabic plurals carry all six forms
- An unset direction follows the locale (Direction::forLocale), so Arabic
  is rtl; a direction the user picked still wins
- The layout cookie keeps only the options chosen, as the users table
  does, so a stored default no longer pins the direction
- TranslationKeysTest compares distinct placeholders, since Arabic repeats
  :count across its plural forms

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Sidebar side is logical: start is the right in rtl, so it no longer
  overlaps the content; "Sidebar end" no longer overlaps it in ltr either
- Logical utilities in the table, select, dropdown, command, dialog and
  sheet primitives; breadcrumb, submenu and panel icons mirror in rtl
- Verification codes and the ⌘K hint stay left to right
- theme-lint's physical-direction rule now covers components/ui, with the
  genuinely physical lines allowlisted
- ArabicTest checks the switch to Arabic and where the sidebar sits

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DevPlus31
DevPlus31 force-pushed the feat/arabic-spanish-locales branch from 01e8816 to 64c7fee Compare October 29, 2026 22:50
@DevPlus31
DevPlus31 merged commit 2314dde into main Oct 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant