Repository navigation
feat: Spanish and Arabic, with right-to-left support - #38
Merged
Merged
Conversation
- Spanish (es) and Arabic (ar) catalogues for the shell and every module, Laravel's validation/auth/passwords/pagination groups, and the legal document templates; Arabic plurals carry all six forms - An unset direction follows the locale (Direction::forLocale), so Arabic is rtl; a direction the user picked still wins - The layout cookie keeps only the options chosen, as the users table does, so a stored default no longer pins the direction - TranslationKeysTest compares distinct placeholders, since Arabic repeats :count across its plural forms Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Sidebar side is logical: start is the right in rtl, so it no longer overlaps the content; "Sidebar end" no longer overlaps it in ltr either - Logical utilities in the table, select, dropdown, command, dialog and sheet primitives; breadcrumb, submenu and panel icons mirror in rtl - Verification codes and the ⌘K hint stay left to right - theme-lint's physical-direction rule now covers components/ui, with the genuinely physical lines allowlisted - ArabicTest checks the switch to Arabic and where the sidebar sits Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DevPlus31
force-pushed
the
feat/arabic-spanish-locales
branch
from
October 29, 2026 22:50
01e8816 to
64c7fee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Languages
es) and Arabic (ar) for the shell, every module, Laravel's validation/auth/passwords/pagination groups, and the legal document templateslaravel-react-i18nboth pick among them)Right to left
Direction::forLocale), so Arabic reads rtl; a direction the user picked still winssideis logical (start = right in rtl): it no longer overlaps the content in rtl, and "Sidebar end" no longer overlaps it in ltrtheme-lint's physical-direction rule now coverscomponents/uiTest plan
ArabicTest) against a production build;ArabicTestfails against the old sidebar🤖 Generated with Claude Code