Add ACCDE build support by delegating compile and app-config to msaccess-vcs-build - #45
Open
pflugs30 wants to merge 1 commit into
Open
Add ACCDE build support by delegating compile and app-config to msaccess-vcs-build#45pflugs30 wants to merge 1 commit into
pflugs30 wants to merge 1 commit into
Conversation
…ess-vcs-build Detect source folders whose name ends in .accde, build them from source, and compile them to an ACCDE. Access builds now delegate compile and prepare to the msaccess-vcs-build subaction rather than local scripts: - Main.ps1 tracks .accde folders separately and emits access-de-folders / has-access-de outputs. - The main action adds a "Build Access ACCDE (if detected)" step that calls the subaction with compile:true, plus new app-config, vcs-url, and vcs-sha inputs threaded through to both the .accdb and .accde build paths. - The subaction bumps its pin to msaccess-vcs-build@v1.1.0 (prepare-before-compile), forwards app-config to each call, and renames expected-sha256 to vcs-sha. - vcs-url now defaults to the joyfullservice msaccess-vcs-addin v5.0.1 release. - Adds an AccessDatabase.accde source fixture and an example Application-Config.json.
Author
|
full disclosure: I've been using Github Copilot extensively to help me make the PRs across the multiple layers. I've reviewed everything manually, but let me know if you have any questions. |
Owner
|
Thanks for the PR, I've just approved the workflow run and I should be able to review this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the approach agreed on #14.
What
Adds Microsoft Access
.accde(compiled) build support. Source folders whosename ends in
.accdeare detected, built from source, and compiled to an ACCDE.Per the discussion on #14, Access builds now delegate both compile and
prepare (app-config) to the
msaccess-vcs-buildsubaction rather thancarrying local build scripts, so
VBA-Buildstays a thin wrapper.Changes
.accdefolders separately and emitsaccess-de-foldersand
has-access-deoutputs.subaction with
compile: true. Three new inputs are threaded through to boththe
.accdband.accdebuild paths:app-config- application config file (database properties, procedures torun, modules/references to remove).
vcs-url- themsaccess-vcs-addinrelease to use for Access builds.vcs-sha- optional expected SHA256 of the add-in asset (named per yourrequest on Support .accde files #14).
msaccess-vcs-build@v1.1.0(which runs prepare before compile, so a singlecall now handles build + prepare + compile), forwards
app-configto eachcall, and renames
expected-sha256->vcs-sha.AccessDatabase.accdesource fixture and an exampleApplication-Config.json;tests.ymlreports ACCDE detection.Points to confirm
vcs-urldefault. I set it to the upstream joyfullservicemsaccess-vcs-addinv5.0.1 release (immutable tag). Happy to change thisif you'd prefer a different default.
msaccess-vcs-buildaction,now pinned to
v1.1.0, which added the prepare-before-compile behavior thisrelies on.
Testing
tests.ymlbuilds the new.accdefixture from source withcompile: true.The
Application-Config.jsonis included as a documented example; the defaulttest run does not pass
app-config, matching the existing.accdbpath.