Skip to content

fix: Add INSERT statements to DAG planning - #2278

Merged
ferenc-csaky merged 1 commit into
mainfrom
fix/add-inserts-to-dag
Aug 13, 2026
Merged

fix: Add INSERT statements to DAG planning#2278
ferenc-csaky merged 1 commit into
mainfrom
fix/add-inserts-to-dag

Conversation

@ferenc-csaky

@ferenc-csaky ferenc-csaky commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Key Changes

  • Model Flink SQL INSERT statements as DAG export nodes with source lineage.
  • Preserve the original RichSqlInsert for execution, retaining target columns and modifiers.
  • Move INSERT enqueueing into DAGPlanner for deterministic statement-set ordering.
  • Add mutation-table INSERT regression coverage and update affected snapshots.

Fixes #1921

@ferenc-csaky ferenc-csaky added the bug Something isn't working label Aug 12, 2026
@ferenc-csaky
ferenc-csaky force-pushed the fix/add-inserts-to-dag branch from 36d3c4c to 6c5ebfc Compare August 12, 2026 15:30
@ferenc-csaky
ferenc-csaky force-pushed the fix/add-inserts-to-dag branch from 6c5ebfc to 55a9e02 Compare August 12, 2026 15:41
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.74%. Comparing base (ea2cf01) to head (55a9e02).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...in/java/com/datasqrl/planner/SqlScriptPlanner.java 0.00% 22 Missing ⚠️
.../com/datasqrl/planner/Sqrl2FlinkSQLTranslator.java 0.00% 18 Missing ⚠️
...main/java/com/datasqrl/planner/dag/DAGPlanner.java 0.00% 8 Missing ⚠️
...ava/com/datasqrl/planner/dag/nodes/ExportNode.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2278      +/-   ##
============================================
- Coverage     18.78%   18.74%   -0.05%     
  Complexity     1223     1223              
============================================
  Files           630      630              
  Lines         18409    18455      +46     
  Branches       2250     2251       +1     
============================================
  Hits           3459     3459              
- Misses        14618    14664      +46     
  Partials        332      332              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ferenc-csaky
ferenc-csaky merged commit d90fead into main Aug 13, 2026
18 of 19 checks passed
@ferenc-csaky
ferenc-csaky deleted the fix/add-inserts-to-dag branch August 13, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capture INSERT statements in DAG

2 participants