refactor(profiling): reduce anyhow, avoid panics#1990
Closed
morrisonlevi wants to merge 2 commits into
Closed
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
==========================================
+ Coverage 72.63% 72.64% +0.01%
==========================================
Files 451 451
Lines 74687 74722 +35
==========================================
+ Hits 54249 54282 +33
- Misses 20438 20440 +2
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 929e50f | Docs | Datadog PR Page | Give us feedback! |
Contributor
Author
|
Meh not focused enough, closing for more focused PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mostly this introduces new Error structs instead of using anyhow for some internal operations (not public API changes, unless you count changing exact error messages to be a breaking change).
This also avoids some panics. We do more
try_reserve*stuff, and also remove some hopefully unreachable panics, such as:It also extracts a helper function
expand_label_setto fallibly convert a&LabelSetto aVec<Label>, add endpoint info, and reserve the spare memory for the timestamp label which gets added later. (Note that it's added later because we have many observations with the same sets of labels, but the timestamp label will differ)Motivation
We've also seen rare panics in some of the profiling FFI functions in crash reports. On Windows we don't have the panic message so I'm not exactly sure why. So I'm working on avoiding panics and ratcheting up the code quality so we have fewer failures all around.
Additionally, anyhow collects a call stack on failure and it's not cheap, plus it allocates for this. We don't want either.
Additional Notes
Some changes like moving constants are in preparation for another PR, but the changes are fine independent of that. This is also why changing the internal functions from anyhow to
FfiSafeErrorMessagestructs will help me: in that PR, we'll haveddog_prof_Profile_serialize2which doesn't useanyhow, and reuses these internal helpers.This is also blocked on #1988 merging first.
How to test the change?
Aside from the exact error messages displayed and possibly having fewer panics, this should test and act the same!