Skip to content

perf(profiling): observation map doesn't need HashDos protection #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morrisonlevi wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

perf(profiling): observation map doesn't need HashDos protection #1988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libdd-profiling/src/internal/observation/observations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ use crate::internal::Timestamp;
use std::collections::HashMap;
use std::io;

type Hasher = core::hash::BuildHasherDefault<rustc_hash::FxHasher>;

struct NonEmptyObservations {
// Samples with no timestamps are aggregated in-place as each observation is added
aggregated_data: AggregatedObservations,
Expand Down Expand Up @@ -131,7 +133,7 @@ impl Observations {
#[derive(Default)]
struct AggregatedObservations {
obs_len: ObservationLength,
data: HashMap<Sample, TrimmedObservation>,
data: HashMap<Sample, TrimmedObservation, Hasher>,
}

impl AggregatedObservations {
Expand Down
Loading