feat(sidecar)!: Add direct exec capabilities to the sidecar via dynamic linker#1980
Conversation
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
When searching for .o symbols to weaken cross reference only with EXPORTED symbols from the php binary.
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
changed the title
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c33c315448
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
==========================================
- Coverage 72.65% 72.51% -0.15%
==========================================
Files 450 451 +1
Lines 74021 74481 +460
==========================================
+ Hits 53781 54008 +227
- Misses 20240 20473 +233
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 3944df6 | Docs | Datadog PR Page | Give us feedback! |
bwoebi
force-pushed
the
bob/direct-exec
branch
2 times, most recently
from
fd9efde to
c419edd
Compare
bwoebi
changed the title
bwoebi
force-pushed
the
bob/direct-exec
branch
3 times, most recently
from
fc36482 to
25f74ed
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Signed-off-by: Bob Weinand <[email protected]>
| if p_type == 3 { | ||
| // PT_INTERP = 3; the interpreter string lives at this vaddr. | ||
| interp_vaddr = p_vaddr; |
There was a problem hiding this comment.
| if p_type == 3 { | |
| // PT_INTERP = 3; the interpreter string lives at this vaddr. | |
| interp_vaddr = p_vaddr; | |
| if p_type == libc::PT_INTERP { | |
| interp_vaddr = p_vaddr; |
Can't we do just that ?
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This PR is rejected because it was updated |
Signed-off-by: Bob Weinand <[email protected]>
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
4 participants
Via
-Wl,-e,ddog_spawn_direct_entry_bodythe sidecar can now be directly executed by invoking it via/lib64/ld-linux-*.so.2(we read it from PT_INTERP).This avoids memfd/tempfile and fexecve() shenanigans by default.