Skip to content

test: guard against leaked enabled=True between llmobs tests - #20845

Merged
emmettbutler merged 1 commit into
mainfrom
emmett.butler/llmobs-test-leak
Oct 9, 2026
Merged

emmettbutler merged 1 commit into
mainfrom
emmett.butler/llmobs-test-leak

Conversation

@emmettbutler

Copy link
Copy Markdown
Collaborator

Guards against the failure mode observed here by resetting enabled in a finally block.

@emmettbutler
emmettbutler requested a review from a team as a code owner October 6, 2026 20:49
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T20:53:19.695926Z ed94490 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

Changelog | Validate changelog

View more details · View in GitHub Actions

pr-name | pr_name_lint

View more details · View in GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ed94490 | Docs | View more details | Give us feedback!

@emmettbutler emmettbutler changed the title tests: guard against leaked enabled=True between llmobs tests test: guard against leaked enabled=True between llmobs tests Oct 6, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 1 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 174 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 174 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=125)
ddtrace.llmobs._utils -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=123)
ddtrace.llmobs._integrations.openai_agents -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=123)
ddtrace.internal.ci_visibility.api._base -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=123)
ddtrace.internal.test_visibility.api -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=123)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@emmettbutler
emmettbutler merged commit 81aed4b into main Oct 9, 2026
303 of 306 checks passed
@emmettbutler
emmettbutler deleted the emmett.butler/llmobs-test-leak branch October 9, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant