Repository navigation
fix(llmobs): apply tracer.set_tags() tags to LLM Observability spans - #20681
FouadWahabi wants to merge 2 commits into
Conversation
LLM Obs span tags were seeded from config.tags, which only holds DD_TAGS. Tags added later with tracer.set_tags() live in tracer._tags and reached APM spans but not LLM Obs spans. Seed from tracer._tags, which already includes DD_TAGS.
Codeowners resolved asResolved from the full PR diff against |
Circular import analysis
|
Dependency direction analysis
|
|
/merge |
|
View all feedbacks in Devflow UI.
The base branch of this pull request is currently frozen (see incident #61179). If you need to change something else, your pull request can still be merged by commenting |
|
/merge |
|
View all feedbacks in Devflow UI.
The base branch of this pull request is currently frozen (see incident #61179). If you need to change something else, your pull request can still be merged by commenting |
|
/merge |
|
View all feedbacks in Devflow UI.
The base branch of this pull request is currently frozen (see incident #61179). If you need to change something else, your pull request can still be merged by commenting |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Description
LLM Obs span tags were seeded from
config.tags(DD_TAGSonly), so tags added withtracer.set_tags()reached APM spans but not LLM Obs spans. Seed fromtracer._tagsinstead, which already includesDD_TAGS.Testing
Added
test_tracer_set_tags_applied_to_llmobs_spans. Also verified end-to-end in staging with a pydantic-ai app.Risks
LLM Obs spans now also carry tags from
tracer.set_tags(), same as APM spans.