Skip to content

helper-rust: redact telemetry logs waf data#3884

Open
cataphract wants to merge 1 commit into
masterfrom
glopes/tel-logs-redact
Open

helper-rust: redact telemetry logs waf data#3884
cataphract wants to merge 1 commit into
masterfrom
glopes/tel-logs-redact

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

Description

Avoid the possibility of sensitive data going to the backend via WAF strings.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner May 18, 2026 14:29
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e97224a83e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread appsec/helper-rust/src/telemetry/tel_aware_logger.rs Outdated
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented May 18, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1 Test failed

telemetry log redacts WafString contents() from com.datadog.appsec.php.integration.TelemetryTests   View in Datadog   (Fix with Cursor)
groovy.lang.MissingMethodException: No signature of method: com.datadog.appsec.php.integration.TelemetryTests$1.traceFromRequest() is applicable for argument types: (String, j.n.h.HttpResponse$BodyHandlers$$Lambda$1219/0x00007fa2f432f8a8, c.d.a.p.i.TelemetryTests$_telemetry_log_redacts_WafString_contents_closure98) values: [/send_request_exec_before_init.php, java.net.http.HttpResponse$BodyHandlers$$Lambda$1219/0x00007fa2f432f8a8@128a188a, ...]
Possible solutions: traceFromRequest(java.lang.String), traceFromRequest(java.lang.String, groovy.lang.Closure), traceFromRequest(java.lang.String, groovy.lang.Closure, boolean), traceFromRequest(java.net.http.HttpRequest, java.net.http.HttpResponse$BodyHandler), traceFromRequest(java.net.http.HttpRequest, java.net.http.HttpResponse$BodyHandler, groovy.lang.Closure), traceFromRequest(java.net.http.HttpRequest, java.net.http.HttpResponse$BodyHandler, groovy.lang.Closure, boolean)

groovy.lang.MissingMethodException: No signature of method: com.datadog.appsec.php.integration.TelemetryTests$1.traceFromRequest() is applicable for argument types: (String, j.n.h.HttpResponse$BodyHandlers$$Lambda$1219/0x00007fa2f432f8a8, c.d.a.p.i.TelemetryTests$_telemetry_log_redacts_WafString_contents_closure98) values: [/send_request_exec_before_init.php, java.net.http.HttpResponse$BodyHandlers$$Lambda$1219/0x00007fa2f432f8a8@128a188a, ...]
Possible solutions: traceFromRequest(java.lang.String), traceFromRequest(java.lang.String, groovy.lang.Closure), traceFromRequest(java.lang.String, groovy.lang.Closure, boolean), traceFromRequest(java.net.http.HttpRequest, java.net.http.HttpResponse$BodyHandler), traceFromRequest(java.net.http.HttpRequest, java.net.http.HttpResponse$BodyHandler, groovy.lang.Closure), traceFromRequest(java.net.http.HttpRequest, java.net.http.HttpResponse$BodyHandler, groovy.lang.Closure, boolean)
	at app//org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)
	at app//com.datadog.appsec.php.integration.TelemetryTests$1.methodMissing(TelemetryTests.groovy)
	at [email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at [email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at [email protected]/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.70% (-0.05%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 149e41c | Docs | Datadog PR Page | Give us feedback!

@cataphract cataphract force-pushed the glopes/tel-logs-redact branch from e97224a to 149e41c Compare May 18, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants