Remove deprecated startSpan and use integration name for telemetry#11181
Draft
Remove deprecated startSpan and use integration name for telemetry#11181
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056893
Total [baseline] (11.176 s) : 0, 11176267
Agent [candidate] (1.064 s) : 0, 1064351
Total [candidate] (11.175 s) : 0, 11174691
section appsec
Agent [baseline] (1.269 s) : 0, 1269312
Total [baseline] (10.993 s) : 0, 10993419
Agent [candidate] (1.266 s) : 0, 1266084
Total [candidate] (11.016 s) : 0, 11015893
section iast
Agent [baseline] (1.245 s) : 0, 1244536
Total [baseline] (11.31 s) : 0, 11310394
Agent [candidate] (1.23 s) : 0, 1229965
Total [candidate] (11.407 s) : 0, 11406958
section profiling
Agent [baseline] (1.183 s) : 0, 1183031
Total [baseline] (10.975 s) : 0, 10975383
Agent [candidate] (1.193 s) : 0, 1193342
Total [candidate] (11.022 s) : 0, 11022052
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.23 ms) : 0, 1230
BytebuddyAgent [baseline] (632.098 ms) : 0, 632098
BytebuddyAgent [candidate] (635.528 ms) : 0, 635528
AgentMeter [baseline] (29.61 ms) : 0, 29610
AgentMeter [candidate] (29.766 ms) : 0, 29766
GlobalTracer [baseline] (249.45 ms) : 0, 249450
GlobalTracer [candidate] (250.272 ms) : 0, 250272
AppSec [baseline] (32.431 ms) : 0, 32431
AppSec [candidate] (32.592 ms) : 0, 32592
Debugger [baseline] (59.838 ms) : 0, 59838
Debugger [candidate] (60.253 ms) : 0, 60253
Remote Config [baseline] (605.859 µs) : 0, 606
Remote Config [candidate] (593.656 µs) : 0, 594
Telemetry [baseline] (8.778 ms) : 0, 8778
Telemetry [candidate] (8.07 ms) : 0, 8070
Flare Poller [baseline] (6.79 ms) : 0, 6790
Flare Poller [candidate] (9.813 ms) : 0, 9813
section appsec
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (679.315 ms) : 0, 679315
BytebuddyAgent [candidate] (678.41 ms) : 0, 678410
AgentMeter [baseline] (12.252 ms) : 0, 12252
AgentMeter [candidate] (12.136 ms) : 0, 12136
GlobalTracer [baseline] (250.371 ms) : 0, 250371
GlobalTracer [candidate] (249.062 ms) : 0, 249062
AppSec [baseline] (187.084 ms) : 0, 187084
AppSec [candidate] (186.731 ms) : 0, 186731
Debugger [baseline] (66.057 ms) : 0, 66057
Debugger [candidate] (65.99 ms) : 0, 65990
Remote Config [baseline] (571.879 µs) : 0, 572
Remote Config [candidate] (581.317 µs) : 0, 581
Telemetry [baseline] (7.967 ms) : 0, 7967
Telemetry [candidate] (7.885 ms) : 0, 7885
Flare Poller [baseline] (3.517 ms) : 0, 3517
Flare Poller [candidate] (3.493 ms) : 0, 3493
IAST [baseline] (24.435 ms) : 0, 24435
IAST [candidate] (24.17 ms) : 0, 24170
section iast
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (818.221 ms) : 0, 818221
BytebuddyAgent [candidate] (807.992 ms) : 0, 807992
AgentMeter [baseline] (11.559 ms) : 0, 11559
AgentMeter [candidate] (11.354 ms) : 0, 11354
GlobalTracer [baseline] (241.278 ms) : 0, 241278
GlobalTracer [candidate] (238.438 ms) : 0, 238438
AppSec [baseline] (28.709 ms) : 0, 28709
AppSec [candidate] (28.554 ms) : 0, 28554
Debugger [baseline] (66.049 ms) : 0, 66049
Debugger [candidate] (65.566 ms) : 0, 65566
Remote Config [baseline] (543.537 µs) : 0, 544
Remote Config [candidate] (534.383 µs) : 0, 534
Telemetry [baseline] (7.896 ms) : 0, 7896
Telemetry [candidate] (7.758 ms) : 0, 7758
Flare Poller [baseline] (3.412 ms) : 0, 3412
Flare Poller [candidate] (3.403 ms) : 0, 3403
IAST [baseline] (29.391 ms) : 0, 29391
IAST [candidate] (28.326 ms) : 0, 28326
section profiling
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (690.635 ms) : 0, 690635
BytebuddyAgent [candidate] (696.848 ms) : 0, 696848
AgentMeter [baseline] (9.155 ms) : 0, 9155
AgentMeter [candidate] (9.26 ms) : 0, 9260
GlobalTracer [baseline] (206.866 ms) : 0, 206866
GlobalTracer [candidate] (208.425 ms) : 0, 208425
AppSec [baseline] (32.808 ms) : 0, 32808
AppSec [candidate] (33.218 ms) : 0, 33218
Debugger [baseline] (65.583 ms) : 0, 65583
Debugger [candidate] (66.376 ms) : 0, 66376
Remote Config [baseline] (585.492 µs) : 0, 585
Remote Config [candidate] (591.768 µs) : 0, 592
Telemetry [baseline] (7.84 ms) : 0, 7840
Telemetry [candidate] (7.863 ms) : 0, 7863
Flare Poller [baseline] (3.555 ms) : 0, 3555
Flare Poller [candidate] (3.61 ms) : 0, 3610
ProfilingAgent [baseline] (93.747 ms) : 0, 93747
ProfilingAgent [candidate] (94.175 ms) : 0, 94175
Profiling [baseline] (94.327 ms) : 0, 94327
Profiling [candidate] (94.725 ms) : 0, 94725
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052598
Total [baseline] (8.839 s) : 0, 8838969
Agent [candidate] (1.059 s) : 0, 1059133
Total [candidate] (8.823 s) : 0, 8823028
section iast
Agent [baseline] (1.229 s) : 0, 1228897
Total [baseline] (9.583 s) : 0, 9582607
Agent [candidate] (1.24 s) : 0, 1239857
Total [candidate] (9.573 s) : 0, 9573036
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.229 ms) : 0, 1229
BytebuddyAgent [baseline] (630.918 ms) : 0, 630918
BytebuddyAgent [candidate] (634.857 ms) : 0, 634857
AgentMeter [baseline] (29.471 ms) : 0, 29471
AgentMeter [candidate] (29.621 ms) : 0, 29621
GlobalTracer [baseline] (248.42 ms) : 0, 248420
GlobalTracer [candidate] (249.671 ms) : 0, 249671
AppSec [baseline] (32.296 ms) : 0, 32296
AppSec [candidate] (32.462 ms) : 0, 32462
Debugger [baseline] (58.939 ms) : 0, 58939
Debugger [candidate] (59.152 ms) : 0, 59152
Remote Config [baseline] (595.053 µs) : 0, 595
Remote Config [candidate] (597.963 µs) : 0, 598
Telemetry [baseline] (7.991 ms) : 0, 7991
Telemetry [candidate] (8.041 ms) : 0, 8041
Flare Poller [baseline] (6.671 ms) : 0, 6671
Flare Poller [candidate] (7.396 ms) : 0, 7396
section iast
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (808.517 ms) : 0, 808517
BytebuddyAgent [candidate] (816.939 ms) : 0, 816939
AgentMeter [baseline] (11.38 ms) : 0, 11380
AgentMeter [candidate] (11.506 ms) : 0, 11506
GlobalTracer [baseline] (238.14 ms) : 0, 238140
GlobalTracer [candidate] (240.482 ms) : 0, 240482
AppSec [baseline] (29.04 ms) : 0, 29040
AppSec [candidate] (28.318 ms) : 0, 28318
Debugger [baseline] (62.071 ms) : 0, 62071
Debugger [candidate] (62.686 ms) : 0, 62686
Remote Config [baseline] (533.951 µs) : 0, 534
Remote Config [candidate] (520.402 µs) : 0, 520
Telemetry [baseline] (7.706 ms) : 0, 7706
Telemetry [candidate] (7.705 ms) : 0, 7705
Flare Poller [baseline] (3.385 ms) : 0, 3385
Flare Poller [candidate] (3.391 ms) : 0, 3391
IAST [baseline] (30.834 ms) : 0, 30834
IAST [candidate] (30.171 ms) : 0, 30171
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (17.405 ms) : 17230, 17580
. : milestone, 17405,
appsec (18.995 ms) : 18803, 19187
. : milestone, 18995,
code_origins (18.038 ms) : 17861, 18216
. : milestone, 18038,
iast (18.128 ms) : 17944, 18312
. : milestone, 18128,
profiling (18.263 ms) : 18084, 18442
. : milestone, 18263,
tracing (18.534 ms) : 18349, 18718
. : milestone, 18534,
section candidate
no_agent (19.108 ms) : 18919, 19297
. : milestone, 19108,
appsec (18.607 ms) : 18419, 18794
. : milestone, 18607,
code_origins (18.235 ms) : 18056, 18414
. : milestone, 18235,
iast (17.872 ms) : 17696, 18047
. : milestone, 17872,
profiling (18.99 ms) : 18803, 19176
. : milestone, 18990,
tracing (18.124 ms) : 17947, 18301
. : milestone, 18124,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (1.263 ms) : 1250, 1276
. : milestone, 1263,
iast (3.29 ms) : 3243, 3337
. : milestone, 3290,
iast_FULL (5.923 ms) : 5864, 5982
. : milestone, 5923,
iast_GLOBAL (3.578 ms) : 3520, 3636
. : milestone, 3578,
profiling (2.234 ms) : 2211, 2257
. : milestone, 2234,
tracing (1.907 ms) : 1891, 1923
. : milestone, 1907,
section candidate
no_agent (1.249 ms) : 1237, 1261
. : milestone, 1249,
iast (3.196 ms) : 3152, 3240
. : milestone, 3196,
iast_FULL (6.053 ms) : 5991, 6114
. : milestone, 6053,
iast_GLOBAL (3.72 ms) : 3659, 3781
. : milestone, 3720,
profiling (2.236 ms) : 2215, 2257
. : milestone, 2236,
tracing (1.855 ms) : 1839, 1871
. : milestone, 1855,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (15.473 s) : 15473000, 15473000
. : milestone, 15473000,
appsec (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
iast (18.056 s) : 18056000, 18056000
. : milestone, 18056000,
iast_GLOBAL (17.771 s) : 17771000, 17771000
. : milestone, 17771000,
profiling (15.571 s) : 15571000, 15571000
. : milestone, 15571000,
tracing (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
section candidate
no_agent (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
appsec (14.855 s) : 14855000, 14855000
. : milestone, 14855000,
iast (18.906 s) : 18906000, 18906000
. : milestone, 18906000,
iast_GLOBAL (17.88 s) : 17880000, 17880000
. : milestone, 17880000,
profiling (15.047 s) : 15047000, 15047000
. : milestone, 15047000,
tracing (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~2c0be9623a, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (3.817 ms) : 3594, 4040
. : milestone, 3817,
iast (2.28 ms) : 2210, 2351
. : milestone, 2280,
iast_GLOBAL (2.315 ms) : 2244, 2385
. : milestone, 2315,
profiling (2.109 ms) : 2053, 2164
. : milestone, 2109,
tracing (2.075 ms) : 2021, 2128
. : milestone, 2075,
section candidate
no_agent (1.486 ms) : 1475, 1498
. : milestone, 1486,
appsec (3.815 ms) : 3594, 4037
. : milestone, 3815,
iast (2.272 ms) : 2202, 2342
. : milestone, 2272,
iast_GLOBAL (2.313 ms) : 2243, 2383
. : milestone, 2313,
profiling (2.097 ms) : 2042, 2152
. : milestone, 2097,
tracing (2.073 ms) : 2019, 2127
. : milestone, 2073,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes the 4 deprecated
startSpanoverloads fromAgentTracerthat accepted aCharSequencespan name as the only/first argument and defaulted to"datadog"as the instrumentation name:All ~145 call sites across ~143 instrumentation files have been migrated to the non-deprecated form that explicitly passes the integration's own name as the first
Stringargument (matchinginstrumentationNames()[0]from the nearest decorator). This ensures spans are attributed to the correct integration rather than the generic"datadog"default.The private
DEFAULT_INSTRUMENTATION_NAME = "datadog"constant inAgentTraceris also removed; the two remaining deprecated methods inTracerAPI(buildSpan(CharSequence)andsingleSpanBuilder(CharSequence)) now inline the"datadog"literal directly.No behaviour change — this is a pure refactor. The instrumentation name passed to the tracer now matches what each integration already declared as its own name.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.