Fix declaration/definition parameter mismatch in LowECluster::initialize - #200
Open
AndyChappell wants to merge 1 commit into
Open
AndyChappell wants to merge 1 commit into
AndyChappell wants to merge 1 commit into
Conversation
Collaborator
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
Collaborator
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
Collaborator
|
❌ CI build for DUNE Failed at phase build DUNE on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build DUNE phase logs parent CI build details are available through the CI dashboard |
Collaborator
|
❌ CI build for DUNE Failed at phase build DUNE on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build DUNE phase logs parent CI build details are available through the CI dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the silent error identified in Issue 199. The tpc and nhits parameters were swapped between the declaration in the header file and the definition in the source file. As both variables are integers, the compiler does not flag the error.