Skip to content

AndroidX migration#885

Open
TalbotGooday wants to merge 15 commits into
DImuthuUpe:masterfrom
TalbotGooday:master
Open

AndroidX migration#885
TalbotGooday wants to merge 15 commits into
DImuthuUpe:masterfrom
TalbotGooday:master

Conversation

@TalbotGooday

@TalbotGooday TalbotGooday commented May 1, 2020

Copy link
Copy Markdown

The support library artifacts are being deprecated and all future development is going into AndroidX, so there’s no point to avoiding this migration.

UPD: Full-migrated library is here https://github.com/TalbotGooday/AndroidPdfViewer. It also includes some forks from this repo

@katie0809

katie0809 commented Jul 6, 2020

Copy link
Copy Markdown

It seems like current AndroidPdfViewer library doesn't support an application migrated to androidX. Is it right?

@TalbotGooday

Copy link
Copy Markdown
Author

@katie0809 yeah, you are right. Here is a fork with AndroidX https://github.com/TalbotGooday/AndroidPdfViewer

implementation 'com.github.TalbotGooday:AndroidPdfViewer:3.1.0-beta.2'

@katie0809

Copy link
Copy Markdown

@TalbotGooday Thank you, actually I solved problems by adding maven { url 'https://maven.google.com' } to the build.gradle. And I don't know why...='(

@TalbotGooday

Copy link
Copy Markdown
Author

@katie0809 so your problem was not the "migration problem")

polesapart added a commit to polesapart/AndroidPdfViewer that referenced this pull request Jul 10, 2020
@madmas

madmas commented Jul 14, 2020

Copy link
Copy Markdown

👍 look good to me :) @barteksc any chance to get this merged and forge a release?

@madmas

madmas commented Aug 4, 2020

Copy link
Copy Markdown

@TalbotGooday as there seems to be no update in this place, have you consider to continue your fork?

@TalbotGooday

Copy link
Copy Markdown
Author

@madmas it all depends on what desires the community will have) Feel free to create issues in my fork)

@madmas

madmas commented Aug 4, 2020

Copy link
Copy Markdown

@TalbotGooday thanks for the quick response :)
actually, you don't have issues enabled:
grafik

@TalbotGooday

TalbotGooday commented Aug 4, 2020

Copy link
Copy Markdown
Author

@madmas oh, sorry. I will enable this option asap)

UPD: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants