Adding null check for the rendering handler thread#813
Closed
pritamps wants to merge 1 commit into
Closed
Conversation
|
This won't fix the problem, it will just crash a couple lines down when it attempts to access the looper
|
|
This PR #824 should fix the issue. |
Author
|
Good point about the issue just being pushed further down with my attempted fix... And Thanks to @jlo1 for pointing out a fix to the actual issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will prevent the app from crashing if the rendering thread is null when the loading is complete