Skip to content

Adding null check for the rendering handler thread#813

Closed
pritamps wants to merge 1 commit into
DImuthuUpe:masterfrom
pritamps:master
Closed

Adding null check for the rendering handler thread#813
pritamps wants to merge 1 commit into
DImuthuUpe:masterfrom
pritamps:master

Conversation

@pritamps

@pritamps pritamps commented Sep 4, 2019

Copy link
Copy Markdown

This will prevent the app from crashing if the rendering thread is null when the loading is complete

@babramovitch

babramovitch commented Feb 13, 2020

Copy link
Copy Markdown

This won't fix the problem, it will just crash a couple lines down when it attempts to access the looper

renderingHandler = new RenderingHandler(renderingHandlerThread.getLooper(), this);

@jlo1

jlo1 commented Mar 6, 2020

Copy link
Copy Markdown

This PR #824 should fix the issue.

@pritamps

pritamps commented Mar 7, 2020

Copy link
Copy Markdown
Author

Good point about the issue just being pushed further down with my attempted fix... And Thanks to @jlo1 for pointing out a fix to the actual issue!

@pritamps pritamps closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants