Skip to content

feat: 1847 - log optional#366

Merged
StuwiiDev merged 8 commits into
mainfrom
feat/1847/log_optional
Jul 6, 2026
Merged

feat: 1847 - log optional#366
StuwiiDev merged 8 commits into
mainfrom
feat/1847/log_optional

Conversation

@StuwiiDev

@StuwiiDev StuwiiDev commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

All changes effect the reconcilaition mode. Added additional logging of optional configurable properties. Added logging of the address result.
All logs contain SearchId so correlating should be straight forward.

Changes

  • Removed sending optional logging in matching API on reconciliation. All the logging we need can be done from the client and is not used for anything else in matching.
  • Add optional properties white list to log. White list is so that we can securely enable logging only what is expected. Any fields not expected are not logged.
  • Added the Address logical outcome to the log as well
  • Fix: apply app insights to the storage blob processor - had a missing connection string

Validation

  • Run all tests and created new tests for new code
  • Run az bicep files through local validation
  • Run the app locally with test files. Confirmed that expected fields are logged and unexpected fields are not logged.

StuwiiDev added 8 commits July 3, 2026 11:07
This is because they are simply not needed coming from the reconciliation request as it logs it's own completion data
This will aid in avoiding logging anything we are not expecting
use an array as all we need is the names of the fields
@StuwiiDev StuwiiDev requested a review from a team as a code owner July 6, 2026 13:02
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
SUI.Client.GraphQLProcessJob 6% 4%
SUI.Client.Core 93% 87%
Matching 74% 49%
SUI.Client.StorageProcessJob 97% 83%
External 44% 32%
SUI.DBS.Response.Logger.Core 93% 72%
Shared 93% 86%
suiw 100% 100%
AppHost 100% 100%
Summary 68% (4145 / 6111) 49% (1095 / 2224)

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@StuwiiDev StuwiiDev merged commit d74d7ad into main Jul 6, 2026
5 checks passed
@StuwiiDev StuwiiDev deleted the feat/1847/log_optional branch July 6, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants