fuse: invalidate page cache after sync and async direct writes (for redfs-ubuntu-noble-6.8.0-58.60)#127
Merged
hbirth merged 1 commit intoDDNStorage:redfs-ubuntu-noble-6.8.0-58.60from Apr 15, 2026
Conversation
Fixes xfstests generic/451, similar to how commit b359af8 ("fuse: Invalidate the page cache after FOPEN_DIRECT_IO write") fixes xfstests generic/209. Signed-off-by: Cheng Ding <cding@ddn.com>
Collaborator
|
LGTM, but have we checked how much this affects performance? |
Collaborator
|
@cding-ddn do we still need this? |
Collaborator
Author
Sorry for my slow response. We still need this. About the performance, this code works only when aio and buffered io mixed workload, the upstream kernel always has Bernd's patch which does similar thing for dio and buffered io mixed case. |
hbirth
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes xfstests generic/451, similar to how commit b359af8 ("fuse: Invalidate the page cache after FOPEN_DIRECT_IO write") fixes xfstests generic/209.