Skip to content

[WIP] Fix hanging job when recipe has solid and fluid output#200

Closed
Copilot wants to merge 1 commit into
master-26from
copilot/fix-mechanical-squeezer-hanging-job
Closed

[WIP] Fix hanging job when recipe has solid and fluid output#200
Copilot wants to merge 1 commit into
master-26from
copilot/fix-mechanical-squeezer-hanging-job

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 24, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Mechanical Squeezer: Hanging Job when Recipe has Solid & Fluid output</issue_title>
<issue_description>

Issue type:

  • 🐛 Bug

Short description:

When a crafting interface is attached to a Mechanical Squeezer, and is asked to complete a recipe with solid & fluid outputs, the items & fluids will be crafted as expected, but once the outputs are retrieved and put into the network the job queue will never register the job as complete.

Steps to reproduce the problem:

FAIL CASE:
1.) Set up a Mechanical Squeezer with a Fluid Importer, Energy Interface & Crafting Interface on its sides and an item importer on the bottom. Whether the squeezer is set to auto-output fluids is inconsequential
2.) Set up an inventory network to hold the ingredients/outputs - tested with Functional Storage item/fluid drawers as well as vanilla minecraft chests and Mekanism fluid tanks. Make sure this is connected to the importers/crafting interface & everything is all on the same channel
3.) Put a recipe in the crafting interface which outputs a fluid & a solid item. Tested with Menril Log -> 2 Crystallized Menril & 1000mb Menril Resin
4.) Set up a storage terminal on the network and request the recipe to be crafted any number of times
5.) The items will be sent to the machine, they will be crafted, and pulled out of the machine and into the network as normal. Observe the outputs appearing in the inventory in the expected amounts
6.) The job, despite the items being in the network, will never complete

SUCCESS CASE 1:
Same setup as the fail case, but:
1.) Set Disable Craft Check to True on the Crafting Interface
2.) Modify the recipe so that it only outputs either the item or the solid (so in the case of Menril Log recipe, do either Menril Log -> 2 Menril Chunks or Menril Log -> 1000mb Menril Resin)
3.) Observe the job completing and removing itself from the queue

SUCCESS CASE 2:

  1. Instead of placing a crafting interface directly on the machine, use the same recipe as in the fail case and set the crafting interface on a chest. Then send the contents of the chest to the Squeezer. Squeezer outputs can then be sent back into the network.
    2.) Observe the job completing and removing itself from queue

Expected behaviour:

When the output of a recipe appears in the network, the job should complete and clear itself from queue.


Versions:

  • This mod: 1.4.6
  • InDy: Tested on 1.33.0-1832 beta & 1.33.1
  • InTerm: 1.6.28
  • InTun: 1.9.4-632 beta
  • CommonCapabilities: 2.11.4
  • CyclopsCore: 1.29.1
  • Minecraft: 1.21.1
  • Mod loader version: Tested on NeoForge 21.1.211 & NeoForge 21.1.228

Log file:

</issue_description>

Comments on the Issue (you are @copilot in this section)

@rubensworks

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mechanical Squeezer: Hanging Job when Recipe has Solid & Fluid output

2 participants