Repository navigation
Conversation
…pt response, policy checks on hybrid KEM use
…ts read from the key bytes
… and without a KEK or HSM
…ed tuple in Data, no IVCounterNonce)
…apsulate its encapsulation component in ckms bench
Manuthor
requested a deployment
to
xks-remote-approval
October 25, 2026 04:18 — with
GitHub Actions
In progress
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a server
key_encryption_keystored in an HSM,ckms pqc keys create -a ml-kem-768-p256fails with HTTP 500:Hybrid KEM keys (
ConfigurableKEM, nativeX25519MLKEM768/X448MLKEM1024) areByteString-only keys with no OpenSSL representation.Defects fixed
NoEncodingsent every private/public key through OpenSSL (breaks Create, Import, ReKeyKeyPair, Export with aKeyWrappingSpecification)crate/crypto/src/crypto/wrap/wrap_key.rsdecode_unwrapped_keydid not decodeConfigurableKEM*(breaks Encrypt/Decrypt after restart,default_unwrap_type,NotWrappedexport/import)crate/crypto/src/crypto/wrap/unwrap_key.rsKeyFormatTypeother thanPKCS8/Raw, so aConfigurableKEMkey could not be exported with its own formatcrate/server/src/core/operations/export_get.rsImport (D) and
is_pqc_algorithm(E) were already fixed on develop by #1268.Tests
cargo test -p cosmian_kms_crypto --features non-fips --lib test_wrap_unwrap_byte_string_kem_keystests::hsm::test_hsm_allnow runshybrid_kem_lifecycle(crate/server/src/tests/hsm/hybrid_kem_dek.rs): Create, restart (cold cache, HSM unwrap), GetAttributes, Locate, Export with stored format, Import,default_unwrap_type, ReKeyKeyPair, Encrypt/Decrypt (encapsulate/decapsulate), Revoke, Destroy forml-kem-512-p256,ml-kem-768-p256andX25519MLKEM768.Notes
cargo deny checkfails on a RUSTSEC advisory forctutils 0.4.2already present in develop'sCargo.lock.ConfigurableKEMprivate keys aresensitiveby default, so a plain export of them is denied by design; the SoftHSM2 test creates non-sensitive pairs.