Skip to content

fix(editor): wrap time row so save button fits - #105

Open
gentledepp wants to merge 1 commit into
CorrectRoadH:mainfrom
gentledepp:fix/editor-time-row-overflow
Open

gentledepp wants to merge 1 commit into
CorrectRoadH:mainfrom
gentledepp:fix/editor-time-row-overflow

Conversation

@gentledepp

Copy link
Copy Markdown

Fixes #104

Problem

In the time entry editor, every item in the time row is non-shrinking and the row does not wrap. For new entries the "Add time entry" button is wider than "Save", so the row exceeds the 440px dialog and the button overflows.

Fix

Allow the time row to wrap (flex-wrap in EditorTimeRow). When the button does not fit, it moves to its own line, right-aligned (it keeps ml-auto). Rows that fit, such as editing an existing entry with "Save", are unchanged. This also covers longer translations.

Screenshots

Before After
before after

Tests

time-entry-editor.spec.ts and time-entry-full-edit.spec.ts pass locally (17 tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time entry editor: "Add time entry" button overflows the dialog

1 participant