Repository navigation
fix(editor): wrap time row so save button fits - #105
Open
gentledepp wants to merge 1 commit into
Open
gentledepp wants to merge 1 commit into
gentledepp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
Problem
In the time entry editor, every item in the time row is non-shrinking and the row does not wrap. For new entries the "Add time entry" button is wider than "Save", so the row exceeds the 440px dialog and the button overflows.
Fix
Allow the time row to wrap (
flex-wrapinEditorTimeRow). When the button does not fit, it moves to its own line, right-aligned (it keepsml-auto). Rows that fit, such as editing an existing entry with "Save", are unchanged. This also covers longer translations.Screenshots
Tests
time-entry-editor.spec.tsandtime-entry-full-edit.spec.tspass locally (17 tests).