Add storybook

[jens-meisner]

No description provided.

[Copilot]

Pull request overview

Copilot reviewed 130 out of 132 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

tests/storybook/src/runtime/outputs.ts:54

• installLastOpenedEntities starts its polling interval asynchronously after getContentFormService resolves, but the returned cleanup only clears the interval id that exists at cleanup time. If the story unmounts before the promise resolves, the interval will still be created afterwards and leak across story changes/tests.

[Copilot]

Pull request overview

Copilot reviewed 130 out of 132 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

tests/storybook/src/runtime/outputs.ts:54

• installLastOpenedEntities starts its polling setInterval only after getContentFormService() resolves, but the returned cleanup may run before that happens. In that case the interval can still be created later and never cleared, leaking timers and potentially updating a detached element after the story unmounts.

[Copilot]

Pull request overview

Copilot reviewed 130 out of 132 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 130 out of 132 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 130 out of 132 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

tests/storybook/src/runtime/outputs.ts:54

• installLastOpenedEntities starts an async getContentFormService(...).then(...) chain but the returned cleanup only clears the interval. If the scenario is unmounted before the promise resolves, the then callback can still run afterwards and create a new interval that will never be cleared (leak + background polling). Add a disposal flag (and guard) so no interval is created after cleanup.

[Copilot]

Pull request overview

Copilot reviewed 130 out of 132 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

tests/storybook/src/runtime/outputs.ts:54

• installLastOpenedEntities can leave the output element empty until getContentFormService() resolves, causing JSON.parse("") failures in Playwright output helpers, and it can also leak an interval if the story is unmounted before the service promise resolves (the interval would be created after cleanup). Initialize the element to a valid JSON value and make cleanup cancel pending setup + clear only a created interval.

[pkliesch]

this file should be removed, right?

[jens-meisner]

Yes, left it only for the review as explanation. Will delete it

[pkliesch]

why did you remove validate-peer-dependencies?

[jens-meisner]

pnpm already does this: strict-peer-dependencies=true (is the default), so pnpm install fails on missing/conflicting peers — at install time

[Copilot]

Pull request overview

Copilot reviewed 126 out of 128 changed files in this pull request and generated no new comments.

Suppressed comments (1)

tests/storybook/src/runtime/outputs.ts:54

• installLastOpenedEntities starts its polling interval only after getContentFormService() resolves, but the returned cleanup only clears the interval id currently stored. If the story is unmounted before the promise resolves, cleanup runs with id still undefined, and the interval can be created later and never cleared (timer leak / updates after teardown).