fix(desktop): pin the latest published deployment on first install - #490
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 11, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fresh desktop installs currently download v0.0.8 even after a newer deployment is published. Resolve GitHub's latest published release on first setup, then use its exact tag for both the source archive and image manifest. Record that version only after the download succeeds; subsequent starts and repairs retain the installed pin without querying GitHub.
Both Start and provider sign-in use this path. Release discovery and downloading run on a blocking task, with failures reported in the setup UI.
Release dependency: GitHub's latest release is still v0.0.8 as of September 11. This PR removes the fixed selection; a newer deployment containing S5's provider sign-in images still needs to be published. It does not upgrade existing installations or establish that v0.0.8 supports provider sign-in.
Where it runs
Desktop only. The selected tag lives in the existing
.openbot-deploymentfile. No new server state, replica coordination, serialization mechanism, browser fanout, listeners, ports, or schedules.Boundary and audit
The existing gateway and server audit paths are unchanged. Release discovery uses GitHub's public API without credentials; setup failures use the existing deployment error reporting.
Changelog
Added an entry under
Unreleased.Proof
cargo fmt --check,cargo clippy --all-targets -- -D warnings, and the Rust desktop binary build passed on macOS.Reproduce the live download from
desktop/src-tauri:cargo test --lib deployment_release::tests::live_latest_release_is_downloaded_and_pinned -- --ignored --exact --nocaptureThe endpoint's stable-release and public-access behavior was checked against GitHub's documentation.