[CCLCC] Keyboard controls unresponsive in Tips menu fix.

[dendi2008]

This PR will fix keyboard controls being unresponsive in CCLCC Tips menu (Issue #483).

[Enorovan]

Can you check if it's not rather just a matter of modifying PADcustomA in profiles/common/scriptinput.lua

root.PADinput.PAD1UP_LS | root.PADinput.PAD1UP_DIRECT,
root.PADinput.PAD1DOWN_LS | root.PADinput.PAD1DOWN_DIRECT,
root.PADinput.PAD1LEFT_LS | root.PADinput.PAD1LEFT_DIRECT,
root.PADinput.PAD1RIGHT_LS | root.PADinput.PAD1RIGHT_DIRECT,

to

root.PADinput.PAD1UP_LS | root.PADinput.PAD1UP_DIRECT | root.PADinput.PAD1UP,
root.PADinput.PAD1DOWN_LS | root.PADinput.PAD1DOWN_DIRECT | root.PADinput.PAD1DOWN,
root.PADinput.PAD1LEFT_LS | root.PADinput.PAD1LEFT_DIRECT | root.PADinput.PAD1LEFT,
root.PADinput.PAD1RIGHT_LS | root.PADinput.PAD1RIGHT_DIRECT | root.PADinput.PAD1RIGHT,

[dendi2008]

Can you check if it's not rather just a matter of modifying PADcustomA in profiles/common/scriptinput.lua

root.PADinput.PAD1UP_LS | root.PADinput.PAD1UP_DIRECT,
root.PADinput.PAD1DOWN_LS | root.PADinput.PAD1DOWN_DIRECT,
root.PADinput.PAD1LEFT_LS | root.PADinput.PAD1LEFT_DIRECT,
root.PADinput.PAD1RIGHT_LS | root.PADinput.PAD1RIGHT_DIRECT,

to

root.PADinput.PAD1UP_LS | root.PADinput.PAD1UP_DIRECT | root.PADinput.PAD1UP,
root.PADinput.PAD1DOWN_LS | root.PADinput.PAD1DOWN_DIRECT | root.PADinput.PAD1DOWN,
root.PADinput.PAD1LEFT_LS | root.PADinput.PAD1LEFT_DIRECT | root.PADinput.PAD1LEFT,
root.PADinput.PAD1RIGHT_LS | root.PADinput.PAD1RIGHT_DIRECT | root.PADinput.PAD1RIGHT,

It will work. It works even without changing scriptinput.lua (just changing PADcustom to PAD1 in cpp), but right stick on gamepad will also be able to trigger, even during scrolling tips list. But right stick should trigger only when user scrolling text in selected Tip (Note text).

[KKhanhH]

I want to take a look at this a little bit more and see if it's an issue with a missing pad to kb mapping or if it's something we should actually be hard codong in our menu

[dendi2008]

I want to take a look at this a little bit more and see if it's an issue with a missing pad to kb mapping or if it's something we should actually be hard codong in our menu

I also noticed, that even without any changes, if you will hold W/S(also arrows) key, it will trigger fast scrolling.

[dendi2008]

I want to take a look at this a little bit more and see if it's an issue with a missing pad to kb mapping or if it's something we should actually be hard codong in our menu

Okay, I checked. It's an issue with a missing pad to kb mapping. You can scroll Note text with F/R. So, I guess, we should add something like this to scriptinput.lua:

    [16] = {SC._UP, SC._KP_8, SC._W},
    [17] = {SC._DOWN, SC._KP_2, SC._S},
    [18] = {SC._LEFT, SC._KP_4, SC._A},
    [19] = {SC._RIGHT, SC._KP_6, SC._D},

[KKhanhH]

Oh I think I figured out the issue. Basically the mappings are all fine, it's just the implementation of UpdatePADHoldInput isn't correct. The arrow direct keys are supposed to only work when held, not single taps, and tipsmenu is supposed to use the repeat functions, so those are all fine, but since we aren't supposed to set InputButtonWentDown and only InputButtonIsDown, InputButtonRepeatDown doesn't work correctly. UpdatePADHoldInput isn't supposed to use WentDown at all and only use IsDown

[dendi2008]

Oh I think I figured out the issue. Basically the mappings are all fine, it's just the implementation of UpdatePADHoldInput isn't correct. The arrow direct keys are supposed to only work when held, not single taps, and tipsmenu is supposed to use the repeat functions, so those are all fine, but since we aren't supposed to set InputButtonWentDown and only InputButtonIsDown, InputButtonRepeatDown doesn't work correctly. UpdatePADHoldInput isn't supposed to use WentDown at all and only use IsDown

Done, if I understood you correctly.

[KKhanhH]

Would probably need to keep track of previous frame's buttonisdown as a replacement for wentdown

[KKhanhH]

Oh i just saw your commit, that should work

[dendi2008]

Would probably need to keep track of previous frame's buttonisdown as a replacement for wentdown

This done by static uint32_t previousIsDown.