Dialoguepage trifurcation#435
Conversation
763e9c8 to
4843a2e
Compare
| protected: | ||
| DialoguePage* BacklogPage; | ||
| int TextLength = 0; | ||
| std::unique_ptr<BacklogPage> Page; |
There was a problem hiding this comment.
Instead of having a backlogpage pointer per backlog entry (which adds a lot of indirection and fragmentation), could we instead maybe store a vector of backlogpages inside backlog menu (since it's not polymorphic), and then access that in backlogentry with an index and maybe a pointer to the backlogmenu?
If backlog max count should be a bounded value, we should store it in a static array as well.
There was a problem hiding this comment.
Yeah that's definitely a good idea. I'm already working on a commit to fix this, which would also simultaneously add a cap on the number of backlog entries (because right now it'll just keep appending indefinitely), but it's growing kinda large and out of scope for this PR. Mind if I fix this in a later PR?
e8bb1ba to
2408cc4
Compare
e4be9ae to
db44171
Compare
aca992f to
3ec1942
Compare
35adafa to
86fe838
Compare
86fe838 to
ea69eae
Compare
7036042 to
145f1d5
Compare
4f4c958 to
33ed785
Compare
…rse they changed that
…particular for italics support)
ea4463d to
2286ced
Compare
2286ced to
d9fe446
Compare
Enorovan
left a comment
There was a problem hiding this comment.
Review feedbacks, some may be addressed elsewhere :
- You can still open empty backlog in C;HLCC.
- Double linebreaks aren't parsed in Tips Menus.
- Weird case when skipping on "looped" lines in Map Trigger.
- Weird Cursor Pointer in C;CLCC Tips Menu.
- Erin Box is supposed to fade-in/fade-out.
… a LUT Fix STT_Present_0x18 not being properly parsed
All should be fixed now, except for being able to open an empty backlog in C;HLCC. On PS3 this is also possible though, so I don't think that was an issue in the first place |
Trifurcates the
DialoguePageclass into separate instances for dialogue, backlog entries, and tip entriesMoves text parsing to a separate class, with separate directive functions for dialogue, backlog, and tips, handling what is parsed and how
InstMesMain, instead of at the start ofInstMesInstSetMesModeFormatand make the parser use these valuesInstSetMesModeFormatvaluesTest English wordwrapping with https://github.com/CommitteeOfZero/impacto-patch/pull/1
English
TextModesInfoconfig is very negotiable