Skip to content

Fail CLA allowlist build when GitHub API fails - #1

Merged
alexisrolland merged 1 commit into
mainfrom
fix/cla-api-failure-handling
Aug 21, 2026
Merged

alexisrolland merged 1 commit into
mainfrom
fix/cla-api-failure-handling

Conversation

@alexisrolland

Copy link
Copy Markdown
Member

Summary

  • capture the pull request commit API response before processing the author list
  • fail the allowlist step explicitly when gh api fails
  • preserve the valid author-only case where filtering produces no co-authors

Verification

  • parsed the workflow as YAML
  • checked the embedded Bash syntax
  • exercised co-author, author-only, and simulated API-failure scenarios
  • ran git diff --check

Closes Comfy-Org/ComfyUI_frontend#15555

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 45131287-0ef8-4a82-9ff1-33c5f761660c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexisrolland
alexisrolland merged commit 015b202 into main Aug 21, 2026
4 of 6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cla.yml: gh api failure in allowlist pipeline is swallowed (no pipefail), silently shrinking the co-author allowlist

1 participant