Skip to content

Windows quit hardening deferred from #1618: kill order, launch-time tree proof, survivor sweep #1655

Open

Description

@synap5e

#1625 shipped the core of #1618 (waiting for ComfyUI to exit on quit and update). Left for a separate PR with its own Windows QA:

  • the Windows kill-order changes;
  • the launch-time process-tree proof;
  • the quit-time survivor sweep;
  • keptAt.

Related, found by #1625's Windows QA: a process started by ComfyUI's interpreter after quit begins (e.g. a custom node's subprocess) is not waited for; listed as a known limit in #1625.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions