Add run config passthrough to launch and materialise#1
Merged
Conversation
Both commands now accept run config like dg launch does:
--config <path> JSON or YAML file, repeatable, shallow-merged
left to right
--config-json <json> inline JSON, merged last (wins over --config)
Config resolves via resolveRunConfig (src/commands/_runconfig.ts) and
flows into the runConfigData field of ExecutionParams in launchRun /
launchAssetRun, which previously hardcoded {}. With no flag the config
is {}, so default-config behaviour is unchanged.
Motivating case: setting resource config on image_qc_pipeline
(use_vision) without editing the resource default. colflow launch
previously launched every job with default config only.
Adds the yaml dependency for YAML config files and unit tests for the
resolver (merge order, file/inline precedence, error paths).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
colflow launchandcolflow materialisenow accept Dagster run config, matchingdg launchsemantics:--config <path>— JSON or YAML file. Repeatable; files shallow-merge left to right.--config-json <json>— inline JSON. Merged last, wins over--config.Config resolves through
resolveRunConfig(src/commands/_runconfig.ts) and flows into therunConfigDatafield ofExecutionParamsinlaunchRun/launchAssetRun, which previously hardcoded{}. With no flag the config is{}, so default-config behaviour is unchanged.Why
colflow launchpreviously launched every job with default config only (the TUI even says "with default config"). No way to set resource/op config from the CLI. Motivating case: enablinguse_visiononimage_qc_pipelinewithout editing the resource default.colflow launch image_qc_pipeline \ --config-json '{"resources":{"colour_target_qc":{"config":{"use_vision":true}}}}'Changes
src/commands/_runconfig.ts— shared resolver (file + inline, merge order, validation).src/client/index.ts—launchRun/launchAssetRuntake an optionalrunConfigData(default{}).src/commands/{launch,materialise}.ts+src/cli.tsx— flag wiring + help text.yamldependency for YAML config files.tests/runconfig.test.ts— 10 unit tests (merge order, file/inline precedence, error paths).Verification
Tested live against a running Dagster dev server:
bun run typecheckclean,bun test173 pass.Release
Feature bump to
v0.5.0after merge (tag onmaintriggers the compile + homebrew-tap release workflow).